Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version info without json file from HTTP headers #15

Closed
szundi opened this issue Nov 16, 2019 · 3 comments
Closed

Version info without json file from HTTP headers #15

szundi opened this issue Nov 16, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@szundi
Copy link
Collaborator

szundi commented Nov 16, 2019

Hello,

I was thinking that maybe there is a way to remove the need for an additional json file that OTA uses to decide wether there is upgrade required. If the bin file HTTP headers would contain a version number, this could be enough to make a choice. This would be handled an other version of the execHTTPCheck() that reads header info instead of JSON, or maybe if it is an octet-stream, not json, then it would check the headers for version info.

What do you think? Maybe I am biased as I am hosting my bin firmware files on Google Storage Buckets, and it is easy to set headers there. 😄

András

@szundi szundi added the enhancement New feature or request label Nov 16, 2019
@chrisjoyce911
Copy link
Owner

I agree, my original thoughts where to use the json as its easy for anyone .

@szundi
Copy link
Collaborator Author

szundi commented Nov 19, 2019

And it is the correct MVP, as without the json solution, you cannot make this work on every environment. Json makes it possible to do this FOTA in cases when you cannot manipulate headers. Which is the case for the majority of our users who will use some kind of cloud solution, like Dropbox, etc.

When my time allows, I will make a PR for you to review.

@szundi szundi self-assigned this Nov 19, 2019
@chrisjoyce911
Copy link
Owner

Looking forward to reviewing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants