Why don't you use CI Input class to get query string?

[kenjis]

This is simple question.

https://github.com/chriskacerguis/codeigniter-restserver/blob/master/application/libraries/REST_Controller.php#L1436

http://www.codeigniter.com/user_guide/libraries/input.html#CI_Input::get

[softwarespot]

Good point. I just took the old code and didn't think about refactoring it. Though the function is still needed if using the likes of a POST request with query params.

[kenjis]

If you POST (or PUT or DELETE or anything else) request with query string, PHP parses query string and sets $_GET.
So you don't have to parse REQUEST_URI by yourself.

It seems we can refactor the function like below:

    protected function _parse_query()
    {
        $this->_query_args = $this->input->get();
    }

[softwarespot]

I understood. It's a good change 👍 I was only pointing out that _parse_query() is still needed.

[kenjis]

I sent PR.

I wrote functional tests: kenjis/ci-app-for-ci-phpunit-test@fda2365
And okay with 2.7.2.

[chriskacerguis]

Merged PR.