Remove Gemfile.lock and use latest version for dependencies. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing Gemfile.lock in the gem is a bad practice as you are limiting that gem to use the versions which are hardcoded there. If there is no any contraindications for that the gem should use always latest versions for all dependencies.
|
I tested it only on 2.1.3, when I will find some time I will take a look on other versions. |
added 5 commits
October 24, 2014 10:20
According to the specification each invalid response should return an json
object ("error") which will provide information what happen on the server.
There is no reason why jimson should take care of that and translate it to
something else. User should expect to receive for each request (no matter if
this response will success or fail, except Notification requests) an json object
with details about status of that response.
|
How I can merge this pull request to my fork ? |
|
I can send you a PR if you want (just tell which repo), otherwise you can just clone my repo (mitfik:jimson) branch |
|
@mitfik I forked your repo (https://github.com/mitfik/jimson) so I don't have to do anything :D I am not sure if this repo is still maintained, good idea to create a separate project based on this one. thank you for your response +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing Gemfile.lock in the gem is a bad practice as you are limiting that gem
to use the versions which are hardcoded there. If there is no any
contraindications for that the gem should use always latest versions for all
dependencies.