Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /languages endpoint #26

Closed
caugner opened this issue Apr 8, 2020 · 4 comments
Closed

Use /languages endpoint #26

caugner opened this issue Apr 8, 2020 · 4 comments
Assignees

Comments

@caugner
Copy link

caugner commented Apr 8, 2020

DeepL now provides an API endpoint to list the supported languages: https://www.deepl.com/docs-api/other-functions/listing-supported-languages

Using this endpoint avoids having to adapt the library for every new language.

Note: With PT-BR and PT-PT, DeepL now also supports two variations: https://www.deepl.com/en/blog/20200402.html

@chriskonnertz chriskonnertz self-assigned this Apr 15, 2020
@chriskonnertz
Copy link
Owner

Hello @caugner ,

so can I add them just as any other language? I guess: yes?

@caugner
Copy link
Author

caugner commented Apr 15, 2020

so can I add them just as any other language? I guess: yes?

Yes, for now you can add them like any other languages (i.e. all uppercase, "PT" is still supported and equivalent to PT-PT).

For the future it would be nice to retrieve the list of supported languages directly from their endpoint.

@caugner
Copy link
Author

caugner commented Apr 15, 2020

@chriskonnertz DeepL also supports Japanese (JA) and Chinese (ZH) since March.

@chriskonnertz
Copy link
Owner

Languages updated.

Decided not to use the language update and rather hard-code the list to avoid trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants