Set minimum TS version to 4.5, use Ember v4 types #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caching means we end up with conflicts between `@types/*` packages, which results in needless conflicts. It is also *much* slower!
Motivation: we need *at least* v4.4 to work with the Ember v4 types, so
we *must* make a breaking change there. However, v4.5 gives us the
very nice `import { type ... }` syntax, and while there are some nice
things in v4.6 and v4.7 we don't particularly need any of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started out with the goal of fixing CI, but then I realized that upgrading to use the Ember v4 types requires bumping to the minimum version of TS supported by those types (4.4). While we could just target v4.4, it's preferable to target v4.5 since that comes with support for the very nice
import { foo, type Bar } from 'somewhere'syntax.@typespackages