Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features not working on tweet details activity #31

Closed
lanzz opened this issue Mar 3, 2013 · 12 comments
Closed

features not working on tweet details activity #31

lanzz opened this issue Mar 3, 2013 · 12 comments
Assignees
Labels
Milestone

Comments

@lanzz
Copy link

lanzz commented Mar 3, 2013

Retweet and favorite buttons don't have any effect; "discussion" constantly shows "no content loaded at this time" and refreshing does not help.

@Fammy
Copy link
Contributor

Fammy commented Mar 5, 2013

Chris is in the process of getting the update to the Play store with these fixes.

@Fammy
Copy link
Contributor

Fammy commented Mar 7, 2013

@lanzz Can you check the latest version in the Play store and see if this works for you know? If so, let's close this issue!

@lanzz
Copy link
Author

lanzz commented Mar 7, 2013

The content in the "discussion" tab now loads, but the "retweeted by" tab is still displaying just "No content loaded at this time". Retweeting kind-of works — the tweet is retweeted, but that is not visible in any way in the interface (I've verified that it works through the Twitter site itself). Tweets that I have retweeted in the past or through the site are also not marked as retweeted on the retweet button itself, both in the tweet details activity or in the long-press popup — they only get the badge on the tweet in the list. It is not possible to un-retweet a previous retweet — clicking the retweet button offers to retweet it again. Retweets are marked visibly on the "timeline" and "my tweets" tabs, but even there it is not possible to un-retweet them — long press on the tweet still shows the retweet button as not-retweeted-yet and offers to retweet again instead of un-retweet. In contrast, the favorite button works correctly now, both in tweet details and in the long-press popup, and un-favoriting works as it should.

@Fammy
Copy link
Contributor

Fammy commented Mar 7, 2013

Thanks for the detailed update. I'll leave this open and look into it soon.

@ghost ghost assigned Fammy Mar 11, 2013
@Fammy
Copy link
Contributor

Fammy commented Mar 12, 2013

Retweeted by appears to work with the latest in the develop branch. I am not sure what changed between 0.72.1 and develop (as of right now) that would have fixed this.

As far as retweeting, did the option to un-retweet work before? I'm not much of a retweeter and never tried to undo a tweet. I'm trying to determine if this is new, desired functionality, or something I broke.

@lanzz
Copy link
Author

lanzz commented Mar 12, 2013

I've only started using TweetLanes recently, and I haven't seen it working yet.

@jamesduffy
Copy link
Collaborator

@lanzz Are you using the version in the Play Store?

@lanzz
Copy link
Author

lanzz commented Mar 12, 2013

Yes.

@Fammy
Copy link
Contributor

Fammy commented Mar 12, 2013

@lanzz can you try this beta version: https://t.co/NlIIkbwH3N

@Fammy
Copy link
Contributor

Fammy commented Mar 13, 2013

Another thing to try is to uninstall and reinstall (or clear data and cache in the settings/apps section, whatever it is called on your phone). The previous caches may not be compatible with changes I've made. I've bumped the cache version on 0.73.0, and this may fix this issue too.

As for un-retweet, can anyone confirm this worked prior to 0.72.0?

@BlythMeister
Copy link
Collaborator

found an issue with this as part of my work for #77
Will include a fix in the pull request for that.

@BlythMeister
Copy link
Collaborator

fixed by #128

@Fammy Fammy closed this as completed Jun 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants