-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI fails to launch when the secret key is unaccessible #3
Comments
When I remove all keys, I get the following exception: |
I was able to do the first-level patch to this. Look for the changes in version 2.0.3. |
Command line works but Gui not.
|
chrislee35
added a commit
that referenced
this issue
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In relation to issue #2, Hideio discovered a GUI launch bug when the secret keys are not found:
selectedKeyIds = new GPGKeyList();
for(GPGKeyId kid : secretKeyList.getKeyIDArray()) <-- crashes here
selectedKeyIds.addKeyId(kid);
I could hide the bug with some exceptions and default values, but I probably should present a warning dialog that no secret keys were found. The tool doesn't need secret keys to encrypt the email, but rather as a way of selecting the public keys that are most likely to be used. Furthermore, it decreases the chance that someone will encrypt to a key that they can't decrypt from.
So, a "fix" would be easy, but the proper interface will take time to think through... I think I'll patch around the issue for a patch-version, and then add the proper interface for a point-version later.
The text was updated successfully, but these errors were encountered: