Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return HTTP 204 instead of 304 when file not changed on volume PUT #1196

Closed
filiphanes opened this issue Feb 11, 2020 · 1 comment
Closed

Comments

@filiphanes
Copy link

When making HTTP PUT request to volume server to already existing fid and sending the same file content, volume server returns status code 304 Not Modified,
but maybe it should return 204 No Content.

From https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/304

It is an implicit redirection to a cached resource. This happens when the request method is safe, like a GET or a HEAD request, ...

As written in https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/204

The common use case is to return 204 as a result of a PUT request, updating a resource, without changing the current content of the page displayed to the user.

Is this behaviour similiar to other existing storage system?

I am aware that this change could cause compatibility issues with old clients.

@chrislusf
Copy link
Collaborator

chrislusf commented Feb 11, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants