ES backended filer support kv ops. #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any way to tell Elastic not to index the content? https://www.elastic.co/guide/en/elasticsearch/reference/current/enabled.html#enabled |
|
separate into an |
chrislusf
reviewed
Sep 4, 2020
| Index(indexKV). | ||
| Type(indexType). | ||
| Id(id). | ||
| Do(context.Background()) |
There was a problem hiding this comment.
there is already a ctx parameter. No need to use context.Background(). Same for other places.
There was a problem hiding this comment.
it can be without indexing if totally no need to query.
There was a problem hiding this comment.
Only need to fetch the value by the key.
chrislusf
reviewed
Sep 4, 2020
| deleteResult, err := store.client.Delete(). | ||
| Index(indexKV). | ||
| Type(indexType). | ||
| Id(id). |
There was a problem hiding this comment.
will cause problem if key contains '/'.
There was a problem hiding this comment.
no need to worry about that.
added 2 commits
September 4, 2020 17:34
2.disable query for kv in es index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.