Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create fuse subcommand to use weed with mount #2085

Merged
merged 2 commits into from May 26, 2021
Merged

create fuse subcommand to use weed with mount #2085

merged 2 commits into from May 26, 2021

Conversation

danielflira
Copy link
Contributor

It add fuse subcommand that allow use weed as mount type.

It's related with issues: #1323 #1674

@prologic
Copy link

This is really nice. 😍

// switch key keeping "weed mount" parameters
switch parts[0] {
case "filer":
mountOptions.filer = &parts[1]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filer now supports comma separated list of filers. Any way to make it work in this mode?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not an issue. Double quoting is required for this case. For example:

                     mount -t tmpfs none /mnt -o \
                       'context="system_u:object_r:tmp_t:s0:c127,c456",noexec'

https://man7.org/linux/man-pages/man8/mount.8.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be a problem. I just split commas without take care of quotes. I going to check it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, please send a new PR to add the example to the help message.

I am going to merge this PR for now.

weed/command/fuse.go Outdated Show resolved Hide resolved
weed/command/fuse.go Outdated Show resolved Hide resolved
@chrislusf chrislusf merged commit e699d16 into seaweedfs:master May 26, 2021
@chrislusf
Copy link
Collaborator

could you please also add a section to https://github.com/chrislusf/seaweedfs/wiki/FUSE-Mount ?

This was referenced May 26, 2021
@danielflira
Copy link
Contributor Author

could you please also add a section to https://github.com/chrislusf/seaweedfs/wiki/FUSE-Mount ?

it was made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants