feat: Added a volume heartbeat graph to grafana dashboard #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current dashboard there is no way to know the status of volume servers, as prometheus only accepts push information, if any server volume goes offline, the last information sent will be read continuously by grafana. Added a graph that calculates the delta between the information of the last push timestamp with the timestamp of 15 seconds ago, if the timestamp has not been changed, server state will be 0, if volume server sent any information the server state will be 1. -This graph will have to be modified if the time interval of pushs is modified, a suggestion for improvement is to send the interval in seconds along with the metrics. -Only local tests were run, maybe if the latency between pushgateway and volume server is too high, the delta calculation could be affected.
|
Nice. Could this be merged with existing dashboards? |
|
Yes, I used the "seaweedfs/k8s/helm_charts2/dashboards/seaweedfs-grafana-dashboard.json" as a base, just added the graph in the volume server information. I created a new file because as I mentioned in the commit, it may be that in a situation of use that takes a little more than 15 seconds to push the metrics, in this case the delta calculation may not work, in the print I sent the volumes are in the same environment than the master, if everything is ok even with external volume servers it can be merged! |
|
thanks and merged. I adjusted the file name to be consistent. Could you please add a README.md file there also? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current dashboard there is no way to know the status of
volume servers, as prometheus only accepts push information, if
any server volume goes offline, the last information sent will
be read continuously by grafana.
Added a graph that calculates the delta between the information
of the last push timestamp with the timestamp of 15 seconds ago,
if the timestamp has not been changed, server state will be 0,
if volume server sent any information the server state will be 1.
-This graph will have to be modified if the time interval of pushs
is modified, a suggestion for improvement is to send the interval
in seconds along with the metrics.
-Only local tests were run, maybe if the latency between pushgateway
and volume server is too high, the delta calculation could be
affected
.