Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filer_http: support uploading file with offset #2694

Merged
merged 1 commit into from Feb 22, 2022
Merged

filer_http: support uploading file with offset #2694

merged 1 commit into from Feb 22, 2022

Conversation

banjiaojuhao
Copy link
Contributor 

# upload data to "offset" position of some_file
> curl -F file=@report.js "http://localhost:8888/javascript/some_file?offset=10"

@chrislusf
Copy link
Collaborator

This is nice. But what are the possible use cases?

@banjiaojuhao
Copy link
Contributor Author

This is nice. But what are the possible use cases?

When uploading large files, user can upload one smaller block in every request, then re-upload blocks that failed to be uploaded according to file metadata.

@chrislusf
Copy link
Collaborator

This API seems simpler than what https://news.ycombinator.com/item?id=27019287 mentioned https://tools.ietf.org/id/draft-wright-http-partial-upload-01.html

@chrislusf
Copy link
Collaborator

This could be used to resume uploading a large file, or upload in chunks.

@chrislusf chrislusf merged commit 5f6f9e9 into seaweedfs:master Feb 22, 2022
@banjiaojuhao banjiaojuhao deleted the filer_http-write_with_offset branch February 23, 2022 16:38
@banjiaojuhao banjiaojuhao restored the filer_http-write_with_offset branch March 7, 2022 07:22
@banjiaojuhao banjiaojuhao mentioned this pull request Mar 7, 2022
Merged
@banjiaojuhao banjiaojuhao deleted the filer_http-write_with_offset branch March 7, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@banjiaojuhao @chrislusf