New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ydb filer store #2996
ydb filer store #2996
Conversation
# Conflicts: # go.mod # go.sum
@chrislusf Checked filer starts here |
@chrislusf I'm done, all tests passed except #3011 |
you may need to add one empty file to the ydb folder, to ensure compilation when "ydb" tag is not defined. |
done |
var name string | ||
var data []byte | ||
for res.NextResultSet(ctx) { | ||
for res.NextRow() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YDB has limit for return rows (default - 1000).
The client code must check Truncated() flag to detect if response truncated (and select next page/return error).
res.CurrentResultSet().Truncated()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rekby How to get this page if the request already has a limit and a start name ?
Perhaps there are regular means without changing the select query ?
SELECT name, meta
FROM filemeta
WHERE dir_hash = $dir_hash AND directory = $directory and name >= $start_name and name LIKE $prefix
ORDER BY name ASC LIMIT $limit;`
Please add some tests similar to |
add some tests seaweedfs#2996
done #3043 |
#2942