Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how Eager app brings in jQuery #3

Merged
merged 1 commit into from Mar 16, 2016
Merged

Conversation

zackbloom
Copy link
Contributor

Including jQuery externally would potentially result in different apps all bringing in their own copy of jQuery. Eager can automatically bundle in jQuery such that it doesn't interfere with any other files on the site.

@chrisma
Copy link
Owner

chrisma commented Mar 16, 2016

Hi Zack,
thanks for the PR! I was wondering how to get Eager to bundle JQuery...
Unfortunately, all the documentation on this I found was in the Guidelines section of the Eager doc, which only speaks of "limited support for bundling jQuery", but doesn't show the code necessary to do that.
Maybe that could be improved?

chrisma pushed a commit that referenced this pull request Mar 16, 2016
Fix how Eager app brings in jQuery
@chrisma chrisma merged commit a1454f5 into chrisma:gh-pages Mar 16, 2016
@zackbloom
Copy link
Contributor Author

Hi @chrisma, Thanks!

There actually is some documentation at the bottom of this page: https://eager.io/developer/docs/install-json/resources. It can be easy to miss, sorry for the confusion!

@zackbloom
Copy link
Contributor Author

@chrisma Thanks again. Do you think you can create a new release so I can import this into Eager and approve the app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants