clean up for v0.8.2

electricjones · Jun 5, 2015 · 38be36f · 38be36f
1 parent 7fefd41
commit 38be36f
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 27 deletions.
diff --git a/src/Contracts/ManagesItemsInterface.php b/src/Contracts/ManagesItemsInterface.php
@@ -16,7 +16,7 @@ interface ManagesItemsInterface
      *
      * @param array $items
      */
-    public function initManager($items);
+    public function initManager($items = []);
 
     /**
      * Adds a single item.

diff --git a/src/Traits/ManagesItemsTrait.php b/src/Traits/ManagesItemsTrait.php
@@ -125,6 +125,11 @@ public function getAll()
         return $this->items;
     }
 
+    /**
+     * Return all items as array
+     *
+     * @return array
+     */
     public function all()
     {
         return $this->getAll();

diff --git a/tests/Stubs/ChainsNestedItemsTraitStub.php b/tests/Stubs/ChainsNestedItemsTraitStub.php
@@ -4,6 +4,10 @@
 use Michaels\Manager\Traits\ChainsNestedItemsTrait;
 use Michaels\Manager\Traits\ManagesItemsTrait;
 
+/**
+ * Class ChainsNestedItemsTraitStub
+ * @package Stubs
+ */
 class ChainsNestedItemsTraitStub
 {
     use ManagesItemsTrait, ChainsNestedItemsTrait;

diff --git a/tests/Stubs/ManagesItemsTraitStub.php b/tests/Stubs/ManagesItemsTraitStub.php
@@ -3,6 +3,10 @@
 
 use Michaels\Manager\Traits\ManagesItemsTrait;
 
+/**
+ * Class ManagesItemsTraitStub
+ * @package Stubs
+ */
 class ManagesItemsTraitStub
 {
     use ManagesItemsTrait;

diff --git a/tests/Traits/ManagesItemsTest.php b/tests/Traits/ManagesItemsTest.php
@@ -71,32 +71,6 @@ public function testInitManagerFromManager()
         $this->assertEquals(['foo' => 'bar'], $secondManager->getAll());
     }
 
-    /* ToDo: Figure out how to make nested objects at initialization pass */
-    /* Use optional flag to flatten objects? */
-    /*public function testInitManagerWithNestedManagers()
-    {
-        $firstManager = new Manager(['five' => 5]);
-        $secondManager = new Manager(['four' => $firstManager]);
-        $thirdManager = new Manager(['three' => $secondManager]);
-        $fourthManager = new Manager(['two' => $thirdManager]);
-        $topManager = new Manager(['one' => $fourthManager]);
-
-        $expected = [
-            'one' => [
-                'two' => [
-                    'three' => [
-                        'four' => [
-                            'five' => 5
-                        ]
-                    ]
-                ]
-            ]
-        ];
-
-        $this->assertEquals($expected, $topManager->getAll());
-        $this->assertEquals(5, $topManager->get("one.two.three.four.five"));
-    }*/
-
     public function testInitManagerFromObject()
     {
         $object = new stdClass();