Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZFormRadioField #8

Closed
Noobish1 opened this issue Feb 6, 2013 · 5 comments
Closed

EZFormRadioField #8

Noobish1 opened this issue Feb 6, 2013 · 5 comments

Comments

@Noobish1
Copy link

Noobish1 commented Feb 6, 2013

Is there a reason why EZFormRadioField uses NSException's instead of NSAsserts?

@jessedc
Copy link
Contributor

jessedc commented Feb 6, 2013

Asserts get compiled out in release builds, I'd assume @chrismiles wants the exceptions to stay there.

@Noobish1
Copy link
Author

Noobish1 commented Feb 6, 2013

Xcode throws errors if the "Enable Objective-C Exceptions" is set to No, which seems to be the default for me in Xcode 4.5.2

EDIT: under further inspection, the default does seems to be Yes, so it's just our project.

@chrismiles
Copy link
Owner

Throwing exceptions to indicate invalid state was a clean way to inform the API user, at the time. I'm not married to them, happy to hear arguments about using assertions instead.

I haven't seen a project not have "Enable Objective-C Exceptions" enabled. Is that common?

@Noobish1
Copy link
Author

Noobish1 commented Feb 7, 2013

I've never come across a project with "Enable Objective-C Exceptions" set to No either, until now. The project is a Unity project with some native code and it seems like Unity is turning it off, NSAsserts work whether it's turned off or not so it seems like a better solution, but thats just me.

@chrismiles
Copy link
Owner

If you can easily work with it as it is, I think we'll just leave it.

However, if this is a show-stopper for your project, shout and I'll consider the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants