Feature - 100% Test Code Coverage #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coverage analysis
code coverage
make this hunk of code covered. :P Awesome.
method in the ServiceProvider class, since session_start() pretty much NEVER returns false....
header output
the basic methods of the Klein class
|
Not sure why I didn't merge this already.... merging. |
Rican7
added a commit
that referenced
this pull request
Sep 29, 2013
Feature - 100% Test Code Coverage
|
Awesome! |
|
Great job with this 👍. Out of interest does PHP have any branch coverage (as opposed to statement & function coverage) tools? |
|
@Rican7 You should add a coverage indicator to the README. |
|
I was thinking of that, @drallen1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you ever seen 100% code coverage in a project before?
Yea... neither have I. :P
I installed PHP_CodeCoverage, saw the high score of most of the files, and then became obsessed with reaching 100%.
Anyway, here's the PR that brings us to 100% code coverage in Klein:
http://reports.dev.metroserve.me/klein-a086f4f-code-coverage/
Yea, shit's cray.