isNumeric to support floating points #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietvanzoen
reviewed
Apr 18, 2018
| @@ -546,7 +546,7 @@ function isAlphanumeric(str) { | |||
| throw new Error('Invalid locale \'' + locale + '\''); | |||
| } | |||
|
|
|||
| var numeric = /^[-+]?[0-9]+$/; | |||
| var numeric = /^[+-]?([0-9]*[.])?[0-9]+$/; | |||
There was a problem hiding this comment.
Hey Amir. The regex looks like it should do the trick but unfortunately it's been implemented directly into the built version of validator.js. You'll want to implement it in the isNumeric source file, update the tests, and run the build and commit any changes.
The source file is this one: https://github.com/chriso/validator.js/blob/master/src/lib/isNumeric.js
There was a problem hiding this comment.
@pietvanzoen , done
|
Thanks for the PR. This has been on the list for a while but it's a breaking change, so I'll add it and bump the major version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue