Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ns.stock format #27

Merged
merged 2 commits into from Dec 5, 2022
Merged

fixed ns.stock format #27

merged 2 commits into from Dec 5, 2022

Conversation

Zerris
Copy link
Contributor

@Zerris Zerris commented Nov 27, 2022

There was a change in how ns.stock api looked for buying and selling since this was originally written. ns.stock.sell replaced with ns.stock.sellStock and the same for the buy version.

This should help anyone who tries to clone after watching the tutorials.

@Zerris
Copy link
Contributor Author

Zerris commented Dec 2, 2022

It was only supposed to issue the first commit and not the experimental second one. Please ignore the money used limited one, as while that did keep it only using 25% of my funds, it resulted in twenty or more stocks bought at any one moment.

Copy link
Owner

@chrisrabe chrisrabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisrabe chrisrabe merged commit 325cf91 into chrisrabe:main Dec 5, 2022
@chrisrabe chrisrabe linked an issue Dec 5, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime Error diamond-hands.js
2 participants