-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERROR `/favicon.png' not found. #19
Comments
Hi, Thanks for reporting this. I added the favicon url from this pull request. I intended to package a default favicon with the theme but it doesn't seem to have worked so I'll take a look at that when I can. Do you think it would be useful to have a variable in the favicon: path/to/favicon.png Then update the head.html to the following: <link rel="shortcut icon" type="image/png" {% if site.favicon %} href="{{ site.favicon | prepend: site.baseurl }}" {% else %} href="{{ site.baseurl }}/favicon.png" {% endif %} /> |
Yes, this fix looks good, thanks! |
@marcello-dev I've updated the readme as suggested and also added the ability to override the default. |
This error shows up when serving the website with the command:
bundle exec jekyll serve
I think is because the favicon.png file is hardcoded here:
bulma-clean-theme/_includes/head.html
Line 6 in 42dcd22
If I download the favicon.png from your repo and put it in my project folder, then the error disappears. But what if I want to change the shortcut icon?
The text was updated successfully, but these errors were encountered: