Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template literals highlighting #238

Closed
mariuslundgard opened this issue Apr 14, 2017 · 4 comments
Closed

Template literals highlighting #238

mariuslundgard opened this issue Apr 14, 2017 · 4 comments

Comments

@mariuslundgard
Copy link

The syntax highlighter is not working correctly for template literals (ES2015):

image

PS. Great tool!
@christianalfoni
Copy link
Owner

Not supported in CodeMirror: codemirror/codemirror5#3026 :-(

But added string color to template literals at least (in next deploy)

@mariuslundgard
Copy link
Author

https://github.com/atom/highlights

@christianalfoni
Copy link
Owner

Yeah, this will not work @mariuslundgard, cause it is codemirror that creates all the HTML. It needs to know everything that is going on to understand what line your are on, character etc. So codemirror has its own parsers. Sorry :(

@mariuslundgard
Copy link
Author

mariuslundgard commented Apr 15, 2017 •
edited
Loading

Ah, makes sense, CodeMirror is not simply syntax highlighting, but a code editor 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mariuslundgard @christianalfoni