Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image includes do not seem to be included in non-default branches #12

Closed
mkobit opened this issue Oct 25, 2016 · 6 comments
Closed

Image includes do not seem to be included in non-default branches #12

mkobit opened this issue Oct 25, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@mkobit
Copy link

mkobit commented Oct 25, 2016

  1. I have a master as my default branch
  2. I push up some .adoc with some image::[] blocks and some .pngs to my-branch
  3. I view the new rendered page

the images do not seem to be included in the rendering of my-branch.
It looks like they are only included when merged into the default branch.

@christiangalsterer
Copy link
Owner

Which plugin and Bitbucket version do you use?

@christiangalsterer
Copy link
Owner

I have tried it with the latest version of the plugin and the latest version of Bitbucket and I can't reproduce the issue. Can you doublecheck that all files have been pushed/merged correctly?

@mkobit mkobit changed the title Image includes do not seem Image includes do not seem to be included in non-default branches Nov 7, 2016
@mkobit
Copy link
Author

mkobit commented Nov 7, 2016

@christiangalsterer sorry, I haven't look back at this but will check again today.

@mkobit
Copy link
Author

mkobit commented Nov 12, 2016

Sorry for taking so long to get back to you, I don't think I described the issue well so hopefully the steps below clarify the issue

Here are the steps I followed locally using the atlas-run-standalone -p 7990 --context-path / --version 4.10.0 --product bitbucket and testing with https://github.com/asciidoctor/jekyll-asciidoc.

  1. Run atlas-run-standalone -p 7990 --context-path / --version 4.10.0 --product bitbucket

  2. Login with admin/admin

  3. Install the 2.3.1 version

  4. Create a repository

  5. Clone down https://github.com/asciidoctor/jekyll-asciidoc, change upstream

    git clone https://github.com/asciidoctor/jekyll-asciidoc.git
    cd jekyll-asciidoc
    git remote set-url origin http://admin@localhost:7990/scm/project_1/my-repo.git
    
  6. Checkout out new branch

    git checkout -b issue-12-repro
    
  7. Download an image

    curl https://www.brandeps.com/logo-download/B/Bitbucket-01.png -o bitbucket-logo.png
    
  8. Make a tweak to the README.adoc to use include::[] macro.

    == Overview
    
    Here is the Bitbucket logo!
    
    image::bitbucket-logo.png[]
    
  9. Add, commit, and push

    git add README.adoc bitbucket-logo.png
    
  10. Preview a pull request to the master branch (http://localhost:7990/projects/PROJECT_1/repos/my-repo/compare/commits?sourceBranch=refs/heads/issue-12-repro)

    Pull request preview

  11. Select the "full source" button

    View full source button

  12. See broken image on page

    Broken image link and source

@christiangalsterer
Copy link
Owner

Hi @mkobit,

thank you very much for the detailed description. I was now able to reproduce the issue. The problem is that the link is created against the configured default branch.

I will look into it and will have a fix hopefully soon.

@christiangalsterer christiangalsterer added this to the 2.3.2 milestone Nov 13, 2016
@christiangalsterer christiangalsterer self-assigned this Nov 13, 2016
@christiangalsterer
Copy link
Owner

The fix is included in the new version 2.3.2 available in the Atlassian Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants