Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE - CNI provider #5

Open
christianh814 opened this issue Oct 15, 2021 · 1 comment
Open

RFE - CNI provider #5

christianh814 opened this issue Oct 15, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@christianh814
Copy link
Owner

Currently, Calico is used as the CNI provider. Although that's a sane default, the option should really be left to the end user. CLI option like...

  • --cni-provider=calico
  • --cni-provider=weavenet
  • --cni-provider=flannel

First pass through, the version is the "latest stable". Future, make that part of the --cni-provider option? (something like --cni-provider=calico3.20)

@christianh814 christianh814 added enhancement New feature or request help wanted Extra attention is needed labels Oct 15, 2021
@christianh814 christianh814 added this to the Alpha 1 release milestone Oct 15, 2021
@NillsF
Copy link
Contributor

NillsF commented Dec 14, 2021

Been giving this some thought as well, and I see a couple of options:

  • Either pass in CNI by name
  • Pass in CNI by linking to a URL

We could even do both.

  • --cni-provider= xxx for well-known CNI providers.
  • --cni-provider-url= xxx for unknown CNI providers.

Given that cluster-api itself doesn't install a CNI provider, I personally think the second approach is a fair option if users need a different CNI provider.

Also, for calico, Azure needs a specific URL. It's coded that way right now in the create azure cluster code. Weave doesn't need this. Not sure how this would work for other CNI providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants