This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
fix(connection): fixing leak in 3.0.0 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlord
approved these changes
Nov 14, 2017
daprahamian
force-pushed
the
NODE-1116-3.0.0
branch
from
a26805f
to
2f671c3
Compare
mbroadst
reviewed
Nov 16, 2017
test/tests/functional/pool_tests.js
Outdated
| expect(connections).to.have.lengthOf(1).and.to.have; | ||
| expect(connections[0].connection.listenerCount('connect')).to.equal(1); | ||
| _pool.destroy(); | ||
| Connection.disableConnectionAccounting(); |
There was a problem hiding this comment.
I think what we actually want to test is that there is a single listener count until connect occurs right? So there should be an initial listener count for that event, and when connect occurs there should be zero listeners. Or am I misunderstanding something?
There was a problem hiding this comment.
I'd expect the listener count to be 0 as well, but there is some listener nestled deep inside of node's core that we don't have control over.
Still, I will refactor to emphasize that the number of listeners for the connection should decrease by 1.
daprahamian
force-pushed
the
NODE-1116-3.0.0
branch
from
2f671c3
to
7cebce7
Compare
mbroadst
approved these changes
Nov 16, 2017
jlord
approved these changes
Nov 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the fix from #234 to 3.0.0 branch.