Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit typing of fromActor #7

Closed
christoph-fricke opened this issue Oct 8, 2021 · 0 comments · Fixed by #9
Closed

Revisit typing of fromActor #7

christoph-fricke opened this issue Oct 8, 2021 · 0 comments · Fixed by #9
Assignees
Labels
bug Something isn't working

Comments

@christoph-fricke
Copy link
Owner

The fromActor service creator should be used to connect a machine to an actor that accepts subscribe events, i.e. a publisher.

The current implementation of fromActor creates some type errors when the helper function is actually used. Some thinks to keep in mind:

  • A received actor might publish more event than the machine is interested in.
  • A machine can handle more events than the events published by the actor.
  • Can we fully type the events that are receivable by the actor?

These have an influence on the type definitions for the machine and actor.

Furthermore, it might be a good idea to send a state update of the actor as an event back to the machine.

@christoph-fricke christoph-fricke added the bug Something isn't working label Oct 8, 2021
@christoph-fricke christoph-fricke self-assigned this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant