Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLAVE_ID vs MASTER_ID #130

Open
BeKl92 opened this issue Feb 15, 2023 · 3 comments
Open

SLAVE_ID vs MASTER_ID #130

BeKl92 opened this issue Feb 15, 2023 · 3 comments

Comments

@BeKl92
Copy link

BeKl92 commented Feb 15, 2023

Is it possible that slave_id and master_id are swapped within the code?

From my understanding the master_id should be the id pyxcp should use to send data to the ecu. The ecu should response with the slave_id. Other xcp implementations used by vector canape or by peakcan xcp driver interpret the master_id as the id used to send data to the ecu and the slave_id used to receive data from the ecu.

So to summarize it according to xcp documentation:
There are at least 2 ids one id for RES/ERR/EV/SERV/DAQ and another one for CMD/STIM.
The id used by the tool to send data is CMD/STIM which should represent the master_id.
The id used by the tool to receive data is RES/ERR/EV/SERV/DAQ which should represent the slave_id.

@tttech-miori
Copy link

Hi,

what you are reporting is also something we have found within my development team.
At the moment, we are work-arounding the issue by simply swapping the meaning in our "manager" layer / config file.
But yes, code shall be fixed or at least documented.

cheers

@BeKl92
Copy link
Author

BeKl92 commented Feb 15, 2023

Thanks for confirming it.
Yes i have also swapped it within the config file.

@neresdu
Copy link

neresdu commented Jun 28, 2023

Yes for me is also swapped it, i've change in the config file and works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants