Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AESConnection offers unauthenticated encryption #3

Open
rraval opened this issue Sep 23, 2014 · 1 comment
Open

AESConnection offers unauthenticated encryption #3

rraval opened this issue Sep 23, 2014 · 1 comment

Comments

@rraval
Copy link

rraval commented Sep 23, 2014

Specifically, once a connection is established, any new message is simply decrypted and shoved into the clipboard.

A MitM can observe the client handshake and then proceed to inject garbage into the receiver's clipboard. MAC'ing the individual messages (after encryption!) and verifying the MAC before decryption should do the right thing here.

A more sophisticated attacker can exploit mallaebility to alter known plaintexts. I'm struggling to come up with a good threat model for this specific scenario though :P

@rraval rraval mentioned this issue Sep 23, 2014
@christophebiocca
Copy link
Owner

Ok. Todo list for this one:

  • Split HMAC into a module.
  • MAC the ciphertext on its way out, MAC-check it on its way in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants