Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rchabin to reviewers #226

Merged
merged 3 commits into from May 24, 2021

Conversation

rchabin
Copy link
Contributor

@rchabin rchabin commented Mar 29, 2021

As an engineering manager, I'm not sure if in your typology I should belong both to frontend and backend teams but this is what seems the more accurate to me.

As an engineering manager, I'm not sure if in your typology I should belong both to frontend and backend teams but this is what seems the more accurate to me.
@reviewflow
Copy link

reviewflow bot commented Mar 29, 2021

Options:

  • 🚦 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.
  • ♻️ Automatically delete the branch after this PR is merged.

@rchabin rchabin changed the title Add rchabin to reviewers feat: Add rchabin to reviewers Mar 29, 2021
@christophehurpeau
Copy link
Owner

Sorry I did not saw this PR ! I don't think you should be in either group, they should match github's team (and will be synced with github's teams one day)

src/accountConfigs/ornikar.ts Outdated Show resolved Hide resolved
src/accountConfigs/ornikar.ts Outdated Show resolved Hide resolved
Rémy Chabin and others added 2 commits May 19, 2021 06:23
Co-authored-by: Christophe Hurpeau <christophe.hurpeau+github@gmail.com>
Co-authored-by: Christophe Hurpeau <christophe.hurpeau+github@gmail.com>
@reviewflow reviewflow bot added 👌 code/needs-review Synced by reviewflow for code/needs-review 👌 code/review-requested Synced by reviewflow for code/review-requested labels May 19, 2021
@reviewflow reviewflow bot added 👌 code/approved Synced by reviewflow for code/approved and removed 👌 code/needs-review Synced by reviewflow for code/needs-review 👌 code/review-requested Synced by reviewflow for code/review-requested labels May 19, 2021
@christophehurpeau christophehurpeau changed the title feat: Add rchabin to reviewers feat: add rchabin to reviewers May 24, 2021
@christophehurpeau christophehurpeau merged commit 6083bee into christophehurpeau:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👌 code/approved Synced by reviewflow for code/approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants