Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable test buckets #145

Closed
8enmann opened this issue Jan 4, 2021 · 5 comments
Closed

Configurable test buckets #145

8enmann opened this issue Jan 4, 2021 · 5 comments

Comments

@8enmann
Copy link
Contributor

8enmann commented Jan 4, 2021

https://github.com/christopher-hesse/blobfile/blob/bb885e72e97ddade675d4493db235b43888a2191/blobfile/_ops_test.py#L30-L36 make it hard for others to contribute, even if they have their own accounts

@christopher-hesse
Copy link
Collaborator

These could be environment variables to make them easily configurable. The bigger issue is that the tests are not run via github actions (and in fact are only run on my desktop computer with the auth setup there). Having them work with github actions would really make it a lot easier for people to contribute.

@christopher-hesse
Copy link
Collaborator

Also, just so you know I only run these tests inside of docker using https://github.com/christopher-hesse/blobfile/blob/master/testing/Dockerfile and I doubt they would work outside of that docker container.

@8enmann
Copy link
Contributor Author

8enmann commented Jan 6, 2021

This is now mostly solved in https://github.com/8enmann/blobfile/tree/aws
I added a gitignore'd .env file that I source before running tests. Probably need to add a reference to it somewhere in the test runner so docker picks up the overrides.

@8enmann
Copy link
Contributor Author

8enmann commented Jan 7, 2021

Fixed by #149

@8enmann 8enmann closed this as completed Jan 7, 2021
@christopher-hesse
Copy link
Collaborator

christopher-hesse commented Jan 7, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants