-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable test buckets #145
Comments
These could be environment variables to make them easily configurable. The bigger issue is that the tests are not run via github actions (and in fact are only run on my desktop computer with the auth setup there). Having them work with github actions would really make it a lot easier for people to contribute. |
Also, just so you know I only run these tests inside of docker using https://github.com/christopher-hesse/blobfile/blob/master/testing/Dockerfile and I doubt they would work outside of that docker container. |
This is now mostly solved in https://github.com/8enmann/blobfile/tree/aws |
Fixed by #149 |
Oh geez now I’m getting emails from Microsoft about how I never answer
their calls.
…On Wed, Jan 6, 2021 at 8:56 PM Ben Mann ***@***.***> wrote:
Closed #145 <#145>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#145 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALSBG2LACCO6C3IRLY5FPDTSYU5GDANCNFSM4VTQT7VA>
.
|
https://github.com/christopher-hesse/blobfile/blob/bb885e72e97ddade675d4493db235b43888a2191/blobfile/_ops_test.py#L30-L36 make it hard for others to contribute, even if they have their own accounts
The text was updated successfully, but these errors were encountered: