Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpful Contribution: For some websites it just shows empty PDF #4

Closed
scorobogaci opened this issue Mar 7, 2021 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@scorobogaci
Copy link

Going through some websites, which are up and running , shows empty PDF.. also many times the styles (css ones) are not applied.. shitty service to be honest, does not work as expected

@ekky1328 ekky1328 added the enhancement New feature or request label Apr 9, 2021
@ekky1328 ekky1328 self-assigned this Apr 9, 2021
@ekky1328 ekky1328 pinned this issue Apr 9, 2021
@ekky1328 ekky1328 changed the title For some websites it just shows empty PDF Helpful Contribution: For some websites it just shows empty PDF Apr 9, 2021
@ekky1328
Copy link
Owner

ekky1328 commented Apr 9, 2021

Hi @scorobogaci,

Given that this example only provides a proof-of-concept on how you can dockerise the dependency Puppeteer and not how to style websites to be print-friendly. This isn't really a helpful issue, however, given you have raised some constructive feedback about my example I'll provide some information to help you out here.

Please reference the API Documentation for page.pdf() here: https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#pagepdfoptions so you understand how the pdf function within puppeteer works.

Just to be clear this is not a "service" this is a free example of how to dockerise an application that requires Puppeteer as a dependency.

Thank you kindly for your time, and I hope this information serves you well in your hunt for a suitable service.

@ekky1328 ekky1328 closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants