Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Using a global simple envelope breaks Sampler's retrigger handling #453

Open
aaronventure opened this issue Dec 1, 2023 · 4 comments

Comments

@aaronventure
Copy link

  1. Create a global modulator container.
  2. Create a Simple Envelope.
  3. Create a Sampler. Set the retrigger mode to "Do Nothing" so you can play repeating notes indefinitely. Hold the pedal for sustain to check that they are in fact stacking.
  4. Replace the Sampler's default simple envelope by the global one, because you're cool and want to control it all in one place.
  5. The sampler's retrigger mode breaks, and new notes will now override already playing notes, causing them to be killed off with a click.
@davidhealey
Copy link
Contributor

Probably related - https://forum.hise.audio/topic/8582/global-adsr-issues

@aaronventure
Copy link
Author

Kinda silly how much time I've spent refactoring my MIDI processor architecture and scripts over the past two days to try and track down why it was behaving the certain way, when this stronzo was just sitting there the entire time. So I reverted back to before I took the whole thing apart, swapped it out for the normal/local modulator and... all problems are gone.

@christoph-hart
Copy link
Collaborator

A bit late to the party but have you used this:

https://docs.hise.audio/scripting/scripting-api/synth/index.html#setuseuniformvoicehandler

regardless, I think for your project using multiple local envelopes is the way to go.

@aaronventure
Copy link
Author

A bit late to the party but have you used this:

https://docs.hise.audio/scripting/scripting-api/synth/index.html#setuseuniformvoicehandler

regardless, I think for your project using multiple local envelopes is the way to go.

I haven't, the However you need to ensure that beyond that point every sound generator will start not more than one voice for each incoming MIDI event. bit was a dealbreaker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants