-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Storybook v5 #91
Comments
@chrisvxd - Storybook v4 to v5 seemed to be a less severe jump than 3 to 4. Do you have an idea of what aspects of story2sketch would break in an upgrade to 5? (Awesome project by the way.) |
Hi @gabriel-kohen-jdas However, when importing into sketch, all I get is a "Stories" layer with nothing inside. What do you think could be the issue? |
Any progress with this issue? I'm using Storybook 5 and can generate the json file, but Sketch throws and error that layers couldn't be imported :/ |
Are there any updates to this, I would hate to have to download storybook for this software? |
Partly because I can't even find the documentation for v4.x.x |
@jakub-bujakowski did you find an issue as I have the same problem |
@jrwpatterson @jakub-bujakowski @njradford @gabriel-kohen-jdas The below works for me in 6.0 alpha actually:
** story2sketch.config.js is required, where the INPUT and OUTPUT directories are specified. Make sure the above commands work in your package.json scripts: |
I was able to duplicate @FarisSum solution with the following config in 6.0.0-beta.0 but you do need to build storybook first, then run against the built version
Although this does "work" I then get the errors from #59 ... could be related, could be just me |
Instead of using stories: "all", try utilizing the layoutBy + specify the individual stories in story2sketch.config.js:
You can also try groupBy, which will create multiple JSON files. Perhaps you will find if any particular story it the root cause of the layer errors. Curious what you get... |
I was able to get it to work by rolling sketch back to v63.1 , YMMV, but my issue was caused by html-sketchapp/html-sketchapp#191 not #59 |
Any update on this ? |
I was able to get this running with Sketch v69.2 and Storybook v6 by using the updated asketch2sketch plugin that is available in html-sketchapp v4.4.1. Without this update, no layers could be imported. For background on this fix, see html-sketchapp/html-sketchapp#196. My commands:
I did get a
Screenshot: |
Closed by #103, thanks again @itsderek23! |
Landed officially in |
It seems like the latest supported is v4.
Most new updates to storybook are done to v5
The text was updated successfully, but these errors were encountered: