Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer jwt versions (>=2.1.0) #24

Closed
wants to merge 1 commit into from

Conversation

gencer
Copy link

@gencer gencer commented May 14, 2018

Due to strict versioning, jwt may clash with existing other gems. To fix this, we allow JWT lib equal and greater then 1.5.2

See: #23 and #21

@coveralls
Copy link

coveralls commented May 14, 2018

Coverage Status

Coverage decreased (-12.2%) to 84.706% when pulling c7df4ec on gencer:patch-1 into cbc68b5 on chriswarren:master.

@gencer
Copy link
Author

gencer commented May 14, 2018

Hm.. I'm thinking this failures could be the reason of Ruby v2.2.1 targeted. Will test more then update PR.

Due to strict versioning, jwt may clash with existing other gems. To fix this, we allow JWT lib equal and greater then 1.5.2
@gencer gencer changed the title Allow newer jwt versions (>=1.5.2) Allow newer jwt versions (>=2.1.0) May 15, 2018
@chriswarren
Copy link
Collaborator

It looks like 11 of the 12 failures are around 2 identical problems, so getting tests passing hopefully won't be too bad.

I won't be able to merge this until you've addressed them. I think doing that should raise the test coverage back up as well.

If you're not interested in doing that we can close this until I have time to look at it, but I don't know when that will be.

@nbulaj
Copy link
Member

nbulaj commented Sep 12, 2018

Closing in favor of #27

@nbulaj nbulaj closed this Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants