Adding ECDSA JWT Functions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| secret_key.generate_key | ||
| public_key = OpenSSL::PKey::EC.new secret_key | ||
| public_key.private_key = nil | ||
|
|
There was a problem hiding this comment.
Trailing whitespace detected.
christopherhein
force-pushed
the
chore/adding-ecdsa-encryption
branch
from
d10edd0
to
3453b31
Compare
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Final newline missing.
christopherhein
force-pushed
the
chore/adding-ecdsa-encryption
branch
from
3453b31
to
54d803b
Compare
| Doorkeeper::JWT.configuration.secret_key | ||
| end | ||
| def secret_key | ||
| return secret_key_file if !secret_key_file.nil? |
There was a problem hiding this comment.
Favor unless over if for negative conditions.
Why: * This allows anyone to use any of the three ecdsa encryption functions
christopherhein
force-pushed
the
chore/adding-ecdsa-encryption
branch
from
54d803b
to
4d2ae34
Compare
|
@chriswarren, not sure if this is something that you'd want in |
|
@chriswarren any chance you can take a look at this? |
|
Sorry for the delay on getting to this - it looks great. Thanks for adding it. I'll merge it in and get it pushed up to RubyGems tonight. |
chriswarren
added a commit
that referenced
this pull request
Feb 17, 2016
Adding ECDSA JWT Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: