Improved HTML escaping in index anchors.

chromatic · Mar 23, 2012 · a1df6dd · a1df6dd
1 parent 8df68b9
commit a1df6dd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/lib/Pod/PseudoPod/DOM/Role/XHTML.pm b/lib/Pod/PseudoPod/DOM/Role/XHTML.pm
@@ -246,8 +246,7 @@ sub encode_index_anchor
 
     $text =~ s/^\*//;
     $text =~ s/[\s"]//g;
-    $text =~ s/</&lt;/g;
+    $text = encode_entities($text);
-    $text =~ s/>/&gt;/g;
 
     return $text;
 }

diff --git a/t/html/escapes.t b/t/html/escapes.t
@@ -83,6 +83,9 @@ like_string $result, qr/<a name="codeanditalicstext1">/,
 like_string $result, qr/<a name="&lt;=&gt;;numericcomparisonoperator1">/,
     '... and should escape <> symbols';
 
+like_string $result, qr/<a name="sigils;&amp;1">/,
+    '... in index anchors as well';
+
 like_string $result, qr/<li>\$BANG BANG\$<p>/,
     'escapes work inside items first line';
 

diff --git a/t/test_file.pod b/t/test_file.pod
@@ -82,6 +82,7 @@ behavior (C<$some_variable-->) should be fine too. C<'single quotes'> need to
 be single quotes, not fancy curly apostrophes.
 
 X<Special formatting>
+X<sigils; &>
 
 Index entries are more fun, as more special characters must be escaped, with a
 quote sign. E.g. X<negation ! operator>, X<array @ sigil>, X<the pipe |> and