Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically updated stylesheets may not have pseudo states applied #86

Closed
ghengeveld opened this issue Aug 14, 2023 · 5 comments
Closed

Comments

@ghengeveld
Copy link
Member

ghengeveld commented Aug 14, 2023

The addon currently processes every stylesheet in the document only once. It marks the stylesheet as "rewritten" and will never touch it again. However, sometimes a stylesheet might get updated dynamically, e.g. as a result of switching a theme global. In such cases any newly injected CSS rules will not get rewritten for pseudo states, because their parent stylesheet has been rewritten before.

Likely the solution would be to mark individual CSS rules as having been rewritten, rather than the stylesheet as a whole.

@Flirre
Copy link

Flirre commented Oct 4, 2023

@ghengeveld
My team is (probably) experiencing this bug right now. Any reason why #87 isn't merged and released?

@ghengeveld
Copy link
Member Author

#87 is a potential performance regression. It needs more testing to verify it performs well.

@Flirre
Copy link

Flirre commented Oct 11, 2023

Hopefully it's not rude to ask, but is there a timeline or estimation for when this would be done?

@ghengeveld
Copy link
Member Author

Working on it today. Ran into a snag though, so this might need a little more work.

@ghengeveld
Copy link
Member Author

Shipped in v2.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants