Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the screenshot funcs to match the behavior of chrome commands #1221

Merged
merged 1 commit into from Jan 9, 2023
Merged

update the screenshot funcs to match the behavior of chrome commands #1221

merged 1 commit into from Jan 9, 2023

Conversation

ZekeLu
Copy link
Member

@ZekeLu ZekeLu commented Dec 12, 2022

Fixes #1220.

@ZekeLu
Copy link
Member Author

ZekeLu commented Dec 12, 2022

Here are the chrome commands:

image

It seems that the behavior changed in Chrome 108.

@ZekeLu
Copy link
Member Author

ZekeLu commented Dec 12, 2022

The test failed because it tests with chromedp/headless-shell:latest, which is chromedp/headless-shell:107.0.5304.107 as of now.

@ZekeLu ZekeLu merged commit 3ab75da into chromedp:master Jan 9, 2023
@ZekeLu ZekeLu deleted the screenshot branch January 9, 2023 03:26
@ZekeLu ZekeLu mentioned this pull request Jun 14, 2023
Closed
@ZekeLu ZekeLu mentioned this pull request Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cepture screenshot returns full height screenshot instead of viewport height
1 participant
@ZekeLu