Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards Compatability? #617

Closed
swizzley opened this issue May 8, 2020 · 2 comments
Closed

Backwards Compatability? #617

swizzley opened this issue May 8, 2020 · 2 comments

Comments

@swizzley
Copy link

swizzley commented May 8, 2020

A Few Questions:

  1. Why was backwards compatibility broken without a major release?
  2. What version of chrome broke compatibility with chromedp from 46a6388
  3. What would be your recommendation for deploying a chromdp app inside a container to use headless mode?

I am asking no. 3 because I am trying to convert an app that was built on CentOS 7 with chrome-stable 64.0.3282.167 using the version from the commit in no. 2 to run in google's docker container golang:latest which is deb 10. I've tried the latest versions of chromium and chrome, and the latest on OSX to run this fully functional app, but chromedp.New fails to initialize, and timesout. I assume it has to do with some breaking change in chrome, though I haven't figured out what that might be. I don't want to nest a container inside a container, and I really wasn't following your docker build that well of headless-chrome which appeared to be hundreds of lines long, which makes me think I missed something when my install is 2 commands. I'm grasping at straws here if it weren't obvious, so any help would be appreciated to avoid re-writing our application from scratch to be in sync with the latest version.

@mvdan
Copy link
Contributor

mvdan commented May 8, 2020

Why was backwards compatibility broken without a major release?

chromedp and cdproto are both v0. no backwards compatibility promises apply, even though we try to not break unless strictly necessary.

If something is broken on master with the latest chrome stable release, file a bug.

What version of chrome broke compatibility with chromedp from 46a6388

Sorry, I don't get that question.

What would be your recommendation for deploying a chromdp app inside a container to use headless mode?

See the README. https://hub.docker.com/r/chromedp/headless-shell/.

@mvdan
Copy link
Contributor

mvdan commented Jun 8, 2020

No answer, so I assume this question is resolved.

@mvdan mvdan closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants