Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting DefaultNewTargetTimeout #63

Closed
maxhawkins opened this issue May 31, 2017 · 1 comment
Closed

Allow setting DefaultNewTargetTimeout #63

maxhawkins opened this issue May 31, 2017 · 1 comment

Comments

@maxhawkins
Copy link

I am running on a CPU-constrained machine so Chrome takes longer than 3s to boot up. However cdp.New always times out if Chrome hasn't booted within 3s. Could you allow setting this value? This issue is making cdp.New fail probably 50% of the time on my server.

https://github.com/knq/chromedp/blob/ddaa7bc4e77f7c8b35b9754548eaa49635cf9ade/chromedp.go#L86

@mvdan
Copy link
Contributor

mvdan commented Feb 21, 2019

We're working on a v2 redesign of this module, and one of the biggest changes will be to remove all these internal sleeps and hard-coded timeouts. Instead, we'll adapt the API to context.Context properly, so you can set up your own timeouts and cancellation however you want. Stay tuned!

@mvdan mvdan closed this as completed Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants