Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testable page load error #793

Open
robinbraemer opened this issue Apr 18, 2021 · 0 comments
Open

Add testable page load error #793

robinbraemer opened this issue Apr 18, 2021 · 0 comments
Labels
enhancement

Comments

@robinbraemer
Copy link

I have to check the "page load ..." error by strings.Contains(err.Error(), "page load error") which is not best practice.

Could you guys please return an exported error type that we can check errors.Is and get errors.As?

reference:

chromedp/chromedp.go

Line 481 in 5b511f1

loadErr = fmt.Errorf("page load error %s", ev.ErrorText)

@robinbraemer robinbraemer changed the title Add custom page load error Add testable page load error Apr 18, 2021
@ZekeLu ZekeLu mentioned this issue Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZekeLu @robinbraemer