-
Notifications
You must be signed in to change notification settings - Fork 6.6k
/
FoldTransitionControllerUnitTest.java
406 lines (352 loc) · 20.6 KB
/
FoldTransitionControllerUnitTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
package org.chromium.chrome.browser.ui.fold_transitions;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.any;
import static org.mockito.Mockito.anyBoolean;
import static org.mockito.Mockito.anyInt;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.chromium.chrome.browser.ui.fold_transitions.FoldTransitionController.DID_CHANGE_TABLET_MODE;
import static org.chromium.chrome.browser.ui.fold_transitions.FoldTransitionController.KEYBOARD_VISIBILITY_STATE;
import static org.chromium.chrome.browser.ui.fold_transitions.FoldTransitionController.RESUME_HOME_SURFACE_ON_MODE_CHANGE;
import static org.chromium.chrome.browser.ui.fold_transitions.FoldTransitionController.TAB_SWITCHER_VISIBILITY_STATE;
import static org.chromium.chrome.browser.ui.fold_transitions.FoldTransitionController.URL_BAR_EDIT_TEXT;
import static org.chromium.chrome.browser.ui.fold_transitions.FoldTransitionController.URL_BAR_FOCUS_STATE;
import static org.chromium.chrome.browser.ui.fold_transitions.FoldTransitionController.saveHomeSurfaceState;
import android.content.Context;
import android.os.Bundle;
import android.os.Handler;
import androidx.test.core.app.ApplicationProvider;
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.ArgumentCaptor;
import org.mockito.InOrder;
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
import org.robolectric.shadows.ShadowSystemClock;
import org.chromium.base.supplier.ObservableSupplierImpl;
import org.chromium.base.supplier.OneshotSupplierImpl;
import org.chromium.base.test.BaseRobolectricTestRunner;
import org.chromium.chrome.browser.ActivityTabProvider;
import org.chromium.chrome.browser.layouts.LayoutManager;
import org.chromium.chrome.browser.layouts.LayoutStateProvider.LayoutStateObserver;
import org.chromium.chrome.browser.layouts.LayoutType;
import org.chromium.chrome.browser.omnibox.OmniboxFocusReason;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.toolbar.ToolbarManager;
import org.chromium.chrome.features.start_surface.StartSurface;
import org.chromium.components.embedder_support.view.ContentView;
import org.chromium.content_public.browser.WebContents;
import org.chromium.ui.KeyboardVisibilityDelegate;
import org.chromium.ui.base.ViewAndroidDelegate;
import java.util.concurrent.TimeUnit;
/** Unit tests for {@link FoldTransitionController}. */
@RunWith(BaseRobolectricTestRunner.class)
public class FoldTransitionControllerUnitTest {
@Mock
private ToolbarManager mToolbarManager;
@Mock
private LayoutManager mLayoutManager;
@Mock
private Handler mHandler;
@Mock
private ActivityTabProvider mActivityTabProvider;
@Mock
private Tab mActivityTab;
@Mock
private WebContents mWebContents;
@Mock
private ContentView mContentView;
@Mock
private KeyboardVisibilityDelegate mKeyboardVisibilityDelegate;
@Mock
private Bundle mSavedInstanceState;
@Mock
private StartSurface mStartSurface;
@Mock
private OneshotSupplierImpl<StartSurface> mStartSurfaceSupplier;
private FoldTransitionController mFoldTransitionController;
@Before
public void setUp() {
MockitoAnnotations.initMocks(this);
Context context = ApplicationProvider.getApplicationContext();
ViewAndroidDelegate viewAndroidDelegate =
ViewAndroidDelegate.createBasicDelegate(mContentView);
KeyboardVisibilityDelegate.setInstance(mKeyboardVisibilityDelegate);
doNothing().when(mToolbarManager).setUrlBarFocusAndText(anyBoolean(), anyInt(), any());
doNothing().when(mLayoutManager).addObserver(any());
doReturn(true).when(mLayoutManager).isLayoutStartingToShow(LayoutType.BROWSING);
doReturn(mActivityTab).when(mActivityTabProvider).get();
doReturn(context).when(mActivityTab).getContext();
doReturn(mWebContents).when(mActivityTab).getWebContents();
doReturn(viewAndroidDelegate).when(mWebContents).getViewAndroidDelegate();
doNothing().when(mWebContents).scrollFocusedEditableNodeIntoView();
doNothing().when(mKeyboardVisibilityDelegate).showKeyboard(mContentView);
doNothing().when(mLayoutManager).showLayout(anyInt(), anyBoolean());
doReturn(false).when(mToolbarManager).isUrlBarFocused();
doReturn("").when(mToolbarManager).getUrlBarTextWithoutAutocomplete();
initializeController();
}
@After
public void tearDown() {
KeyboardVisibilityDelegate.setInstance(null);
}
@Test
public void testSaveUiState_urlBarFocused() {
String text = "hello";
doReturn(true).when(mToolbarManager).isUrlBarFocused();
doReturn(text).when(mToolbarManager).getUrlBarTextWithoutAutocomplete();
mFoldTransitionController.saveUiState(
mSavedInstanceState, /* didChangeTabletMode= */ true, /* isIncognito= */ false);
verify(mSavedInstanceState).putBoolean(URL_BAR_FOCUS_STATE, true);
verify(mSavedInstanceState).putString(URL_BAR_EDIT_TEXT, text);
}
@Test
public void testSaveUiState_urlBarNotFocused() {
doReturn(false).when(mToolbarManager).isUrlBarFocused();
mFoldTransitionController.saveUiState(
mSavedInstanceState, /* didChangeTabletMode= */ true, /* isIncognito= */ false);
verify(mSavedInstanceState, never()).putBoolean(URL_BAR_FOCUS_STATE, true);
verify(mSavedInstanceState, never()).putString(eq(URL_BAR_EDIT_TEXT), anyString());
}
@Test
public void testSaveUiState_keyboardVisibleOnWebContentsFocus() {
doReturn(true).when(mWebContents).isFocusedElementEditable();
doReturn(true).when(mKeyboardVisibilityDelegate).isKeyboardShowing(any(), any());
mFoldTransitionController.saveUiState(
mSavedInstanceState, /* didChangeTabletMode= */ true, /* isIncognito= */ false);
verify(mSavedInstanceState).putBoolean(KEYBOARD_VISIBILITY_STATE, true);
verify(mWebContents).isFocusedElementEditable();
verify(mKeyboardVisibilityDelegate)
.isKeyboardShowing(mActivityTab.getContext(), mContentView);
}
@Test
public void testSaveUiState_keyboardVisibleOnWebContentsFocus_crbug1426678() {
doReturn(true).when(mWebContents).isFocusedElementEditable();
doReturn(true).when(mKeyboardVisibilityDelegate).isKeyboardShowing(any(), any());
InOrder inOrder = Mockito.inOrder(mSavedInstanceState);
mFoldTransitionController.saveUiState(
mSavedInstanceState, /* didChangeTabletMode= */ true, /* isIncognito= */ false);
inOrder.verify(mSavedInstanceState).putBoolean(KEYBOARD_VISIBILITY_STATE, true);
Assert.assertTrue("|mKeyboardVisibleDuringFoldTransition| should be true.",
mFoldTransitionController.getKeyboardVisibleDuringFoldTransitionForTesting());
Assert.assertNotNull("|mKeyboardVisibilityTimestamp| should not be null.",
mFoldTransitionController.getKeyboardVisibilityTimestampForTesting());
ShadowSystemClock.advanceBy(FoldTransitionController.KEYBOARD_RESTORATION_TIMEOUT_MS - 1,
TimeUnit.MILLISECONDS);
// Simulate a second invocation of Activity#onSaveInstanceState.
doReturn(true).when(mWebContents).isFocusedElementEditable();
doReturn(false).when(mKeyboardVisibilityDelegate).isKeyboardShowing(any(), any());
mFoldTransitionController.saveUiState(
mSavedInstanceState, /* didChangeTabletMode= */ true, /* isIncognito= */ false);
inOrder.verify(mSavedInstanceState).putBoolean(KEYBOARD_VISIBILITY_STATE, true);
Assert.assertFalse("|mKeyboardVisibleDuringFoldTransition| should be reset.",
mFoldTransitionController.getKeyboardVisibleDuringFoldTransitionForTesting());
Assert.assertNull("|mKeyboardVisibilityTimestamp| should be reset.",
mFoldTransitionController.getKeyboardVisibilityTimestampForTesting());
verify(mWebContents, times(2)).isFocusedElementEditable();
verify(mKeyboardVisibilityDelegate, times(2))
.isKeyboardShowing(mActivityTab.getContext(), mContentView);
}
@Test
public void testSaveUiState_keyboardVisible_crbug1426678_stateValidityTimedOut()
throws InterruptedException {
doReturn(true).when(mWebContents).isFocusedElementEditable();
doReturn(true).when(mKeyboardVisibilityDelegate).isKeyboardShowing(any(), any());
InOrder inOrder = Mockito.inOrder(mSavedInstanceState);
mFoldTransitionController.saveUiState(
mSavedInstanceState, /* didChangeTabletMode= */ true, /* isIncognito= */ false);
inOrder.verify(mSavedInstanceState).putBoolean(KEYBOARD_VISIBILITY_STATE, true);
Assert.assertTrue("|mKeyboardVisibleDuringFoldTransition| should be true.",
mFoldTransitionController.getKeyboardVisibleDuringFoldTransitionForTesting());
Assert.assertNotNull("|mKeyboardVisibilityTimestamp| should not be null.",
mFoldTransitionController.getKeyboardVisibilityTimestampForTesting());
ShadowSystemClock.advanceBy(FoldTransitionController.KEYBOARD_RESTORATION_TIMEOUT_MS + 1,
TimeUnit.MILLISECONDS);
// Simulate a second invocation of Activity#onSaveInstanceState.
doReturn(true).when(mWebContents).isFocusedElementEditable();
doReturn(false).when(mKeyboardVisibilityDelegate).isKeyboardShowing(any(), any());
mFoldTransitionController.saveUiState(
mSavedInstanceState, /* didChangeTabletMode= */ true, /* isIncognito= */ false);
inOrder.verify(mSavedInstanceState, never())
.putBoolean(eq(KEYBOARD_VISIBILITY_STATE), anyBoolean());
Assert.assertFalse("|mKeyboardVisibleDuringFoldTransition| should be reset.",
mFoldTransitionController.getKeyboardVisibleDuringFoldTransitionForTesting());
Assert.assertNull("|mKeyboardVisibilityTimestamp| should be reset.",
mFoldTransitionController.getKeyboardVisibilityTimestampForTesting());
verify(mWebContents, times(2)).isFocusedElementEditable();
verify(mKeyboardVisibilityDelegate, times(2))
.isKeyboardShowing(mActivityTab.getContext(), mContentView);
}
@Test
public void testSaveUiState_keyboardNotVisible() {
doReturn(false).when(mWebContents).isFocusedElementEditable();
doReturn(false).when(mKeyboardVisibilityDelegate).isKeyboardShowing(any(), any());
mFoldTransitionController.saveUiState(
mSavedInstanceState, /* didChangeTabletMode= */ true, /* isIncognito= */ false);
verify(mSavedInstanceState, never()).putBoolean(KEYBOARD_VISIBILITY_STATE, true);
}
@Test
public void testSaveUiState_tabSwitcherVisible() {
doReturn(true).when(mLayoutManager).isLayoutVisible(LayoutType.TAB_SWITCHER);
mFoldTransitionController.saveUiState(mSavedInstanceState, /* didChangeTabletMode= */ true,
/* isIncognito= */ false);
verify(mSavedInstanceState).putBoolean(TAB_SWITCHER_VISIBILITY_STATE, true);
}
@Test
public void testSaveUiState_tabSwitcherNotVisible() {
doReturn(false).when(mLayoutManager).isLayoutVisible(LayoutType.TAB_SWITCHER);
mFoldTransitionController.saveUiState(mSavedInstanceState, /* didChangeTabletMode= */ true,
/* isIncognito= */ false);
verify(mSavedInstanceState, never()).putBoolean(TAB_SWITCHER_VISIBILITY_STATE, true);
}
@Test
public void testSaveHomeSurfaceState() {
doReturn(true).when(mSavedInstanceState).getBoolean(DID_CHANGE_TABLET_MODE);
saveHomeSurfaceState(null, mStartSurface, false);
saveHomeSurfaceState(mSavedInstanceState, null, false);
saveHomeSurfaceState(mSavedInstanceState, mStartSurface, true);
verify(mSavedInstanceState, never()).putBoolean(RESUME_HOME_SURFACE_ON_MODE_CHANGE, true);
// Verifies that saved instance state will have RESUME_HOME_SURFACE_ON_MODE_CHANGE == true
// if Start surface is shown on phone.
saveHomeSurfaceState(mSavedInstanceState, mStartSurface, false);
verify(mSavedInstanceState).putBoolean(RESUME_HOME_SURFACE_ON_MODE_CHANGE, true);
}
@Test
public void testSaveUiStateWithTabSwitcherAndStartSurface() {
doReturn(true).when(mSavedInstanceState).getBoolean(DID_CHANGE_TABLET_MODE);
doReturn(true).when(mLayoutManager).isLayoutVisible(LayoutType.TAB_SWITCHER);
// Sets Start surface is disabled.
doReturn(false).when(mStartSurfaceSupplier).hasValue();
// Tests the case when Tab switcher is showing with Start surface disabled.
mFoldTransitionController.saveUiState(mSavedInstanceState, true, false);
verify(mSavedInstanceState, never()).putBoolean(RESUME_HOME_SURFACE_ON_MODE_CHANGE, true);
verify(mSavedInstanceState).putBoolean(TAB_SWITCHER_VISIBILITY_STATE, true);
// Sets Start surface is enabled.
doReturn(true).when(mStartSurfaceSupplier).hasValue();
doReturn(mStartSurface).when(mStartSurfaceSupplier).get();
// Tests the case when Tab switcher is showing with Start surface enabled.
doReturn(false).when(mStartSurface).isHomepageShown();
mFoldTransitionController.saveUiState(mSavedInstanceState, true, false);
verify(mSavedInstanceState, never()).putBoolean(RESUME_HOME_SURFACE_ON_MODE_CHANGE, true);
verify(mSavedInstanceState, times(2)).putBoolean(TAB_SWITCHER_VISIBILITY_STATE, true);
// Tests the case when Start surface is showing with "Start surface refactor" disabled.
doReturn(true).when(mStartSurface).isHomepageShown();
doReturn(true).when(mLayoutManager).isLayoutVisible(LayoutType.TAB_SWITCHER);
mFoldTransitionController.saveUiState(mSavedInstanceState, true, false);
verify(mSavedInstanceState).putBoolean(RESUME_HOME_SURFACE_ON_MODE_CHANGE, true);
verify(mSavedInstanceState, times(2)).putBoolean(TAB_SWITCHER_VISIBILITY_STATE, true);
// Sets the layout when "Start surface refactor" is enabled.
doReturn(false).when(mLayoutManager).isLayoutVisible(LayoutType.TAB_SWITCHER);
doReturn(true).when(mLayoutManager).isLayoutVisible(LayoutType.START_SURFACE);
// Tests the case when Start surface is showing with "Start surface refactor" enabled:
doReturn(true).when(mStartSurface).isHomepageShown();
mFoldTransitionController.saveUiState(mSavedInstanceState, true, false);
verify(mSavedInstanceState, times(2)).putBoolean(RESUME_HOME_SURFACE_ON_MODE_CHANGE, true);
verify(mSavedInstanceState, times(2)).putBoolean(TAB_SWITCHER_VISIBILITY_STATE, true);
}
@Test
public void testRestoreUiState_urlBarFocused_layoutPendingShow() {
String text = "hello";
initializeSavedInstanceState(/* didChangeTabletMode= */ true, /* urlBarFocused= */ true,
text, /* keyboardVisible= */ false, /* tabSwitcherVisible= */ false);
mFoldTransitionController.restoreUiState(mSavedInstanceState);
ArgumentCaptor<LayoutStateObserver> layoutStateObserverCaptor =
ArgumentCaptor.forClass(LayoutStateObserver.class);
verify(mLayoutManager).addObserver(layoutStateObserverCaptor.capture());
// Simulate invocation of Layout#doneShowing after invocation of #restoreUiState.
doReturn(true).when(mLayoutManager).isLayoutVisible(LayoutType.BROWSING);
layoutStateObserverCaptor.getValue().onFinishedShowing(LayoutType.BROWSING);
ArgumentCaptor<Runnable> postRunnableCaptor = ArgumentCaptor.forClass(Runnable.class);
verify(mHandler).post(postRunnableCaptor.capture());
postRunnableCaptor.getValue().run();
verify(mToolbarManager)
.setUrlBarFocusAndText(true, OmniboxFocusReason.FOLD_TRANSITION_RESTORATION, text);
}
@Test
public void testRestoreUiState_urlBarFocused_layoutDoneShowing() {
String text = "hello";
// Assume that Layout#doneShowing is invoked before invocation of #restoreUiState.
doReturn(true).when(mLayoutManager).isLayoutVisible(LayoutType.BROWSING);
doReturn(false).when(mLayoutManager).isLayoutStartingToShow(LayoutType.BROWSING);
initializeSavedInstanceState(/* didChangeTabletMode= */ true, /* urlBarFocused= */ true,
text, /* keyboardVisible= */ true, /* tabSwitcherVisible= */ false);
mFoldTransitionController.restoreUiState(mSavedInstanceState);
verify(mToolbarManager)
.setUrlBarFocusAndText(true, OmniboxFocusReason.FOLD_TRANSITION_RESTORATION, text);
// Omnibox code should restore keyboard.
verify(mKeyboardVisibilityDelegate, never()).showKeyboard(mContentView);
}
@Test
public void testRestoreUiState_keyboardVisibleOnWebContentsFocus_layoutDoneShowing() {
// Assume that Layout#doneShowing is invoked before invocation of #restoreUiState.
doReturn(true).when(mLayoutManager).isLayoutVisible(LayoutType.BROWSING);
doReturn(false).when(mLayoutManager).isLayoutStartingToShow(LayoutType.BROWSING);
initializeSavedInstanceState(/* didChangeTabletMode= */ true, /* urlBarFocused= */ false,
null, /* keyboardVisible= */ true, /* tabSwitcherVisible= */ false);
mFoldTransitionController.restoreUiState(mSavedInstanceState);
verify(mWebContents).scrollFocusedEditableNodeIntoView();
verify(mKeyboardVisibilityDelegate).showKeyboard(mContentView);
}
@Test
public void testRestoreUiState_tabSwitcherVisible() {
initializeSavedInstanceState(/* didChangeTabletMode= */ true, /* urlBarFocused= */ false,
null, /* keyboardVisible= */ false, /* tabSwitcherVisible= */ true);
mFoldTransitionController.restoreUiState(mSavedInstanceState);
verify(mLayoutManager).showLayout(LayoutType.TAB_SWITCHER, false);
}
@Test
public void testRestoreUiState_urlBarNotFocused() {
initializeSavedInstanceState(/* didChangeTabletMode= */ true, /* urlBarFocused= */ false,
null, /* keyboardVisible= */ false, /* tabSwitcherVisible= */ false);
mFoldTransitionController.restoreUiState(mSavedInstanceState);
verify(mLayoutManager, never()).addObserver(any());
verify(mToolbarManager, never()).setUrlBarFocusAndText(anyBoolean(), anyInt(), any());
}
@Test
public void testRestoreUiState_didNotChangeTabletMode() {
String text = "hello";
initializeSavedInstanceState(/* didChangeTabletMode= */ false, /* urlBarFocused= */ true,
text, /* keyboardVisible= */ true, /* tabSwitcherVisible= */ false);
mFoldTransitionController.restoreUiState(mSavedInstanceState);
verify(mLayoutManager, never()).addObserver(any());
verify(mToolbarManager, never()).setUrlBarFocusAndText(anyBoolean(), anyInt(), any());
}
private void initializeSavedInstanceState(boolean didChangeTabletMode, boolean urlBarFocused,
String urlBarText, boolean keyboardVisible, boolean tabSwitcherVisible) {
doReturn(didChangeTabletMode)
.when(mSavedInstanceState)
.getBoolean(DID_CHANGE_TABLET_MODE, false);
// Omnibox state keys.
doReturn(urlBarFocused).when(mSavedInstanceState).getBoolean(URL_BAR_FOCUS_STATE, false);
if (urlBarText != null) {
doReturn(urlBarText).when(mSavedInstanceState).getString(URL_BAR_EDIT_TEXT, "");
}
// Keyboard state key(s).
doReturn(keyboardVisible)
.when(mSavedInstanceState)
.getBoolean(KEYBOARD_VISIBILITY_STATE, false);
// Tab switcher state key.
doReturn(tabSwitcherVisible)
.when(mSavedInstanceState)
.getBoolean(TAB_SWITCHER_VISIBILITY_STATE, false);
}
private void initializeController() {
var toolbarManagerSupplier = new OneshotSupplierImpl<ToolbarManager>();
toolbarManagerSupplier.set(mToolbarManager);
var layoutManagerSupplier = new ObservableSupplierImpl<LayoutManager>();
layoutManagerSupplier.set(mLayoutManager);
mFoldTransitionController = new FoldTransitionController(toolbarManagerSupplier,
layoutManagerSupplier, mActivityTabProvider, mStartSurfaceSupplier, mHandler);
}
}