-
Notifications
You must be signed in to change notification settings - Fork 6.6k
/
autofill_metrics_unittest.cc
10911 lines (9718 loc) · 480 KB
/
autofill_metrics_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/autofill/core/browser/metrics/autofill_metrics.h"
#include "base/check.h"
#include <stddef.h>
#include <memory>
#include <string>
#include <utility>
#include <vector>
#include "base/base64.h"
#include "base/containers/cxx20_erase.h"
#include "base/containers/fixed_flat_map.h"
#include "base/feature_list.h"
#include "base/ios/ios_util.h"
#include "base/memory/raw_ptr.h"
#include "base/metrics/metrics_hashes.h"
#include "base/metrics/statistics_recorder.h"
#include "base/strings/strcat.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/metrics/user_action_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "build/build_config.h"
#include "components/autofill/core/browser/autofill_data_util.h"
#include "components/autofill/core/browser/autofill_external_delegate.h"
#include "components/autofill/core/browser/autofill_form_test_utils.h"
#include "components/autofill/core/browser/autofill_suggestion_generator.h"
#include "components/autofill/core/browser/autofill_test_utils.h"
#include "components/autofill/core/browser/data_model/credit_card.h"
#include "components/autofill/core/browser/field_types.h"
#include "components/autofill/core/browser/form_structure_test_api.h"
#include "components/autofill/core/browser/metrics/autofill_metrics_test_base.h"
#include "components/autofill/core/browser/metrics/form_events/address_form_event_logger.h"
#include "components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.h"
#include "components/autofill/core/browser/metrics/form_events/form_events.h"
#include "components/autofill/core/browser/metrics/payments/credit_card_save_metrics.h"
#include "components/autofill/core/browser/payments/credit_card_access_manager.h"
#include "components/autofill/core/browser/payments/test_credit_card_save_manager.h"
#include "components/autofill/core/browser/payments/test_payments_client.h"
#include "components/autofill/core/browser/personal_data_manager.h"
#include "components/autofill/core/browser/sync_utils.h"
#include "components/autofill/core/browser/test_autofill_client.h"
#include "components/autofill/core/browser/test_autofill_driver.h"
#include "components/autofill/core/browser/test_autofill_tick_clock.h"
#include "components/autofill/core/browser/test_browser_autofill_manager.h"
#include "components/autofill/core/browser/test_form_data_importer.h"
#include "components/autofill/core/browser/test_personal_data_manager.h"
#include "components/autofill/core/browser/ui/popup_item_ids.h"
#include "components/autofill/core/browser/ui/popup_types.h"
#include "components/autofill/core/browser/ui/suggestion.h"
#include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
#include "components/autofill/core/common/autofill_clock.h"
#include "components/autofill/core/common/autofill_features.h"
#include "components/autofill/core/common/autofill_payments_features.h"
#include "components/autofill/core/common/autofill_tick_clock.h"
#include "components/autofill/core/common/dense_set.h"
#include "components/autofill/core/common/form_data.h"
#include "components/autofill/core/common/form_field_data.h"
#include "components/autofill/core/common/form_interactions_flow.h"
#include "components/autofill/core/common/signatures.h"
#include "components/autofill/core/common/unique_ids.h"
#include "components/prefs/pref_service.h"
#include "components/sync/test/test_sync_service.h"
#include "components/translate/core/common/language_detection_details.h"
#include "components/ukm/test_ukm_recorder.h"
#include "components/webdata/common/web_data_results.h"
#include "services/metrics/public/cpp/ukm_builders.h"
#include "services/metrics/public/cpp/ukm_source.h"
#include "services/network/public/cpp/shared_url_loader_factory.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/geometry/rect.h"
#include "url/gurl.h"
#include "url/url_canon.h"
#if !BUILDFLAG(IS_IOS)
#include "components/autofill/core/browser/payments/test_credit_card_fido_authenticator.h"
#endif
using ::autofill::test::AddFieldPredictionToForm;
using ::base::ASCIIToUTF16;
using ::base::Bucket;
using ::base::BucketsAre;
using ::base::BucketsInclude;
using ::base::TimeTicks;
using ::testing::ElementsAre;
using ::testing::HasSubstr;
using ::testing::Matcher;
using ::testing::NiceMock;
using ::testing::UnorderedPointwise;
namespace autofill {
// This is defined in the autofill_metrics.cc implementation file.
int GetFieldTypeGroupPredictionQualityMetric(
ServerFieldType field_type,
AutofillMetrics::FieldTypeQualityMetric metric);
} // namespace autofill
namespace autofill::metrics {
using mojom::SubmissionSource;
using SyncSigninState = AutofillSyncSigninState;
namespace {
using UkmCardUploadDecisionType = ukm::builders::Autofill_CardUploadDecision;
using UkmDeveloperEngagementType = ukm::builders::Autofill_DeveloperEngagement;
using UkmInteractedWithFormType = ukm::builders::Autofill_InteractedWithForm;
using UkmSuggestionsShownType = ukm::builders::Autofill_SuggestionsShown;
using UkmSuggestionFilledType = ukm::builders::Autofill_SuggestionFilled;
using UkmTextFieldDidChangeType = ukm::builders::Autofill_TextFieldDidChange;
using UkmLogHiddenRepresentationalFieldSkipDecisionType =
ukm::builders::Autofill_HiddenRepresentationalFieldSkipDecision;
using UkmLogRepeatedServerTypePredictionRationalized =
ukm::builders::Autofill_RepeatedServerTypePredictionRationalized;
using UkmFormSubmittedType = ukm::builders::Autofill_FormSubmitted;
using UkmFieldTypeValidationType = ukm::builders::Autofill_FieldTypeValidation;
using UkmFieldFillStatusType = ukm::builders::Autofill_FieldFillStatus;
using UkmFormEventType = ukm::builders::Autofill_FormEvent;
using UkmEditedAutofilledFieldAtSubmission =
ukm::builders::Autofill_EditedAutofilledFieldAtSubmission;
using UkmAutofillKeyMetricsType = ukm::builders::Autofill_KeyMetrics;
using UkmFieldInfoType = ukm::builders::Autofill_FieldInfo;
struct ExpectedUkmMetricsPair : public std::pair<const char*, int64_t> {
using std::pair<const char*, int64_t>::pair;
ExpectedUkmMetricsPair(const char* str, HtmlFieldMode mode)
: ExpectedUkmMetricsPair(str, static_cast<int64_t>(mode)) {}
ExpectedUkmMetricsPair(const char* str, HtmlFieldType type)
: ExpectedUkmMetricsPair(str, static_cast<int64_t>(type)) {}
};
using ExpectedUkmMetricsRecord = std::vector<ExpectedUkmMetricsPair>;
using ExpectedUkmMetrics = std::vector<ExpectedUkmMetricsRecord>;
using AddressImportRequirements =
AutofillMetrics::AddressProfileImportRequirementMetric;
FormSignature Collapse(FormSignature sig) {
return FormSignature(sig.value() % 1021);
}
FieldSignature Collapse(FieldSignature sig) {
return FieldSignature(sig.value() % 1021);
}
struct AddressProfileImportRequirementExpectations {
AddressImportRequirements requirement;
bool fulfilled;
};
void VerifyDeveloperEngagementUkm(
const ukm::TestUkmRecorder* ukm_recorder,
const FormData& form,
const bool is_for_credit_card,
const DenseSet<FormType>& form_types,
const std::vector<int64_t>& expected_metric_values) {
int expected_metric_value = 0;
for (const auto it : expected_metric_values)
expected_metric_value |= 1 << it;
auto entries =
ukm_recorder->GetEntriesByName(UkmDeveloperEngagementType::kEntryName);
EXPECT_EQ(1u, entries.size());
for (const auto* const entry : entries) {
ukm_recorder->ExpectEntrySourceHasUrl(
entry, GURL(form.main_frame_origin.GetURL()));
EXPECT_EQ(4u, entry->metrics.size());
ukm_recorder->ExpectEntryMetric(
entry, UkmDeveloperEngagementType::kDeveloperEngagementName,
expected_metric_value);
ukm_recorder->ExpectEntryMetric(
entry, UkmDeveloperEngagementType::kIsForCreditCardName,
is_for_credit_card);
ukm_recorder->ExpectEntryMetric(
entry, UkmDeveloperEngagementType::kFormTypesName,
AutofillMetrics::FormTypesToBitVector(form_types));
ukm_recorder->ExpectEntryMetric(
entry, UkmDeveloperEngagementType::kFormSignatureName,
Collapse(CalculateFormSignature(form)).value());
}
}
MATCHER(CompareMetricsIgnoringMillisecondsSinceFormParsed, "") {
const auto& lhs = ::testing::get<0>(arg);
const std::pair<const char*, int64_t>& rhs = ::testing::get<1>(arg);
return lhs.first == base::HashMetricName(rhs.first) &&
(lhs.second == rhs.second ||
(lhs.second > 0 &&
rhs.first ==
UkmSuggestionFilledType::kMillisecondsSinceFormParsedName));
}
void VerifyUkm(const ukm::TestUkmRecorder* ukm_recorder,
const FormData& form,
const char* event_name,
const ExpectedUkmMetrics& expected_metrics) {
auto entries = ukm_recorder->GetEntriesByName(event_name);
EXPECT_LE(entries.size(), expected_metrics.size());
for (size_t i = 0; i < expected_metrics.size() && i < entries.size(); i++) {
ukm_recorder->ExpectEntrySourceHasUrl(entries[i],
form.main_frame_origin.GetURL());
EXPECT_THAT(
entries[i]->metrics,
UnorderedPointwise(CompareMetricsIgnoringMillisecondsSinceFormParsed(),
expected_metrics[i]));
}
}
void VerifySubmitFormUkm(
const ukm::TestUkmRecorder* ukm_recorder,
const FormData& form,
AutofillMetrics::AutofillFormSubmittedState state,
bool is_for_credit_card,
bool has_upi_vpa_field,
const DenseSet<FormType>& form_types,
const FormInteractionCounts& form_interaction_counts = {}) {
VerifyUkm(ukm_recorder, form, UkmFormSubmittedType::kEntryName,
{{{UkmFormSubmittedType::kAutofillFormSubmittedStateName, state},
{UkmSuggestionFilledType::kMillisecondsSinceFormParsedName, 0},
{UkmFormSubmittedType::kIsForCreditCardName, is_for_credit_card},
{UkmFormSubmittedType::kHasUpiVpaFieldName, has_upi_vpa_field},
{UkmFormSubmittedType::kFormTypesName,
AutofillMetrics::FormTypesToBitVector(form_types)},
{UkmFormSubmittedType::kFormSignatureName,
Collapse(CalculateFormSignature(form)).value()},
{UkmFormSubmittedType::kFormElementUserModificationsName,
form_interaction_counts.form_element_user_modifications},
{UkmFormSubmittedType::kAutofillFillsName,
form_interaction_counts.autofill_fills}}});
}
void AppendFieldFillStatusUkm(const FormData& form,
ExpectedUkmMetrics* expected_metrics) {
FormSignature form_signature = Collapse(CalculateFormSignature(form));
int64_t metric_type = static_cast<int64_t>(AutofillMetrics::TYPE_SUBMISSION);
for (const FormFieldData& field : form.fields) {
FieldSignature field_signature =
Collapse(CalculateFieldSignatureForField(field));
expected_metrics->push_back(
{{UkmSuggestionFilledType::kMillisecondsSinceFormParsedName, 0},
{UkmFieldFillStatusType::kFormSignatureName, form_signature.value()},
{UkmFieldFillStatusType::kFieldSignatureName, field_signature.value()},
{UkmFieldFillStatusType::kValidationEventName, metric_type},
{UkmTextFieldDidChangeType::kIsAutofilledName,
field.is_autofilled ? 1 : 0},
{UkmFieldFillStatusType::kWasPreviouslyAutofilledName, 0}});
}
}
void AppendFieldTypeUkm(const FormData& form,
const std::vector<ServerFieldType>& heuristic_types,
const std::vector<ServerFieldType>& server_types,
const std::vector<ServerFieldType>& actual_types,
ExpectedUkmMetrics* expected_metrics) {
ASSERT_EQ(heuristic_types.size(), form.fields.size());
ASSERT_EQ(server_types.size(), form.fields.size());
ASSERT_EQ(actual_types.size(), form.fields.size());
FormSignature form_signature = Collapse(CalculateFormSignature(form));
int64_t metric_type = static_cast<int64_t>(AutofillMetrics::TYPE_SUBMISSION);
std::vector<int64_t> prediction_sources{
AutofillMetrics::PREDICTION_SOURCE_HEURISTIC,
AutofillMetrics::PREDICTION_SOURCE_SERVER,
AutofillMetrics::PREDICTION_SOURCE_OVERALL};
for (size_t i = 0; i < form.fields.size(); ++i) {
const FormFieldData& field = form.fields[i];
FieldSignature field_signature =
Collapse(CalculateFieldSignatureForField(field));
for (int64_t source : prediction_sources) {
int64_t predicted_type = static_cast<int64_t>(
(source == AutofillMetrics::PREDICTION_SOURCE_SERVER
? server_types
: heuristic_types)[i]);
int64_t actual_type = static_cast<int64_t>(actual_types[i]);
expected_metrics->push_back(
{{UkmSuggestionFilledType::kMillisecondsSinceFormParsedName, 0},
{UkmFieldFillStatusType::kFormSignatureName, form_signature.value()},
{UkmFieldFillStatusType::kFieldSignatureName,
field_signature.value()},
{UkmFieldFillStatusType::kValidationEventName, metric_type},
{UkmFieldTypeValidationType::kPredictionSourceName, source},
{UkmFieldTypeValidationType::kPredictedTypeName, predicted_type},
{UkmFieldTypeValidationType::kActualTypeName, actual_type}});
}
}
}
// For a single submission, test if the right bucket was filled.
void TestAddressProfileImportRequirements(
base::HistogramTester* histogram_tester,
const std::vector<AddressProfileImportRequirementExpectations>&
expectations) {
std::string histogram = "Autofill.AddressProfileImportRequirements";
for (auto& expectation : expectations) {
histogram_tester->ExpectBucketCount(histogram, expectation.requirement,
expectation.fulfilled ? 1 : 0);
}
}
// For country specific address field requirements.
void TestAddressProfileImportCountrySpecificFieldRequirements(
base::HistogramTester* histogram_tester,
AutofillMetrics::AddressProfileImportCountrySpecificFieldRequirementsMetric
metric) {
std::string histogram =
"Autofill.AddressProfileImportCountrySpecificFieldRequirements";
// Test that the right bucket was populated.
histogram_tester->ExpectBucketCount(histogram, metric, 1);
}
void CreateSimpleForm(const GURL& origin, FormData& form) {
form.host_frame = test::MakeLocalFrameToken();
form.unique_renderer_id = test::MakeFormRendererId();
form.name = u"TestForm";
form.url = GURL("http://example.com/form.html");
form.action = GURL("http://example.com/submit.html");
form.main_frame_origin = url::Origin::Create(origin);
}
std::string SerializeAndEncode(const AutofillQueryResponse& response) {
std::string unencoded_response_string;
if (!response.SerializeToString(&unencoded_response_string)) {
LOG(ERROR) << "Cannot serialize the response proto";
return "";
}
std::string response_string;
base::Base64Encode(unencoded_response_string, &response_string);
return response_string;
}
} // namespace
class AutofillMetricsTest : public AutofillMetricsBaseTest {
public:
using AutofillMetricsBaseTest::AutofillMetricsBaseTest;
~AutofillMetricsTest() override = default;
[[nodiscard]] FormData CreateEmptyForm() {
FormData form;
form.host_frame = test::MakeLocalFrameToken();
form.unique_renderer_id = test::MakeFormRendererId();
form.name = u"TestForm";
form.url = GURL("https://example.com/form.html");
form.action = GURL("https://example.com/submit.html");
form.main_frame_origin =
url::Origin::Create(autofill_client_->form_origin());
return form;
}
[[nodiscard]] FormData CreateForm(std::vector<FormFieldData> fields) {
FormData form = CreateEmptyForm();
form.fields = std::move(fields);
return form;
}
// Forwards to test::CreateTestFormField(). This is a hack meant as an
// intermediate step towards removing the out-parameters from
// autofill_form_util.h.
template <typename... Args>
[[nodiscard]] FormFieldData CreateField(Args... args) {
FormFieldData field;
test::CreateTestFormField(args..., &field);
return field;
}
};
// Test parameter indicates if the metrics are being logged for a form in an
// iframe or the main frame. True means the form is in the main frame.
class AutofillMetricsIFrameTest : public testing::WithParamInterface<bool>,
public AutofillMetricsTest {
public:
AutofillMetricsIFrameTest()
: AutofillMetricsTest(
/*is_in_any_main_frame=*/GetParam()),
credit_card_form_events_frame_histogram_(
std::string("Autofill.FormEvents.CreditCard.") +
(is_in_any_main_frame_ ? "IsInMainFrame" : "IsInIFrame")) {}
protected:
const std::string credit_card_form_events_frame_histogram_;
};
INSTANTIATE_TEST_SUITE_P(AutofillMetricsTest,
AutofillMetricsIFrameTest,
testing::Bool());
// Test the logging of the form filling stats for the different form types.
TEST_F(AutofillMetricsTest, FieldFillingStats) {
FormData form = GetAndAddSeenForm(
{.description_for_logging = "FieldFillingStats",
.fields =
{
{.role = NAME_FULL,
.value = u"First Middle Last",
.is_autofilled = true},
// Those two fields are going to be changed to a value of the
// same type.
{.role = NAME_FIRST, .value = u"First", .is_autofilled = true},
{.role = NAME_LAST, .value = u"Last", .is_autofilled = true},
// This field is going to be changed to a value of a different
// type.
{.role = NAME_FIRST, .value = u"First", .is_autofilled = true},
// This field is going to be changed to another value of unknown
// type.
{.role = NAME_FIRST, .value = u"First", .is_autofilled = true},
// This field is going to be changed to the empty value.
{.role = NAME_MIDDLE, .value = u"Middle", .is_autofilled = true},
// This field remains.
{.role = NAME_LAST, .value = u"Last", .is_autofilled = true},
// This following two fields are manually filled to a value of
// type NAME_FIRST.
{.role = NAME_FIRST, .value = u"Elvis", .is_autofilled = false},
{.role = NAME_FIRST, .value = u"Elvis", .is_autofilled = false},
// This one is manually filled to a value of type NAME_LAST.
{.role = NAME_FIRST,
.value = u"Presley",
.is_autofilled = false},
// This next three are manually filled to a value of
// UNKNOWN_TYPE.
{.role = NAME_FIRST,
.value = u"Random Value",
.is_autofilled = false},
{.role = NAME_MIDDLE,
.value = u"Random Value",
.is_autofilled = false},
{.role = NAME_LAST,
.value = u"Random Value",
.is_autofilled = false},
// The last field is not autofilled and empty.
{.role = ADDRESS_HOME_CITY,
.value = u"",
.is_autofilled = false},
// We add two credit cards field to make sure those are counted
// in separate statistics.
{.role = CREDIT_CARD_NAME_FULL,
.value = u"Test Name",
.is_autofilled = true},
{.role = CREDIT_CARD_NUMBER,
.value = u"",
.is_autofilled = false},
},
.unique_renderer_id = test::MakeFormRendererId(),
.main_frame_origin =
url::Origin::Create(autofill_client_->form_origin())});
// Elvis is of type NAME_FIRST in the test profile.
SimulateUserChangedTextFieldTo(form, form.fields[1], u"Elvis");
// Presley is of type NAME_LAST in the test profile
SimulateUserChangedTextFieldTo(form, form.fields[2], u"Presley");
// Presley is of type NAME_LAST in the test profile
SimulateUserChangedTextFieldTo(form, form.fields[3], u"Presley");
// This is a random string of UNKNOWN_TYPE.
SimulateUserChangedTextFieldTo(form, form.fields[4], u"something random");
SimulateUserChangedTextFieldTo(form, form.fields[5], u"");
base::HistogramTester histogram_tester;
SubmitForm(form);
const std::string histogram_prefix = "Autofill.FieldFillingStats.Address.";
histogram_tester.ExpectUniqueSample(histogram_prefix + "Accepted", 2, 1);
histogram_tester.ExpectUniqueSample(histogram_prefix + "CorrectedToSameType",
2, 1);
histogram_tester.ExpectUniqueSample(
histogram_prefix + "CorrectedToDifferentType", 1, 1);
histogram_tester.ExpectUniqueSample(
histogram_prefix + "CorrectedToUnknownType", 1, 1);
histogram_tester.ExpectUniqueSample(histogram_prefix + "CorrectedToEmpty", 1,
1);
histogram_tester.ExpectUniqueSample(histogram_prefix + "LeftEmpty", 1, 1);
histogram_tester.ExpectUniqueSample(
histogram_prefix + "ManuallyFilledToSameType", 2, 1);
histogram_tester.ExpectUniqueSample(
histogram_prefix + "ManuallyFilledToDifferentType", 1, 1);
histogram_tester.ExpectUniqueSample(
histogram_prefix + "ManuallyFilledToUnknownType", 3, 1);
histogram_tester.ExpectUniqueSample(histogram_prefix + "TotalManuallyFilled",
6, 1);
histogram_tester.ExpectUniqueSample(histogram_prefix + "TotalFilled", 7, 1);
histogram_tester.ExpectUniqueSample(histogram_prefix + "TotalCorrected", 5,
1);
histogram_tester.ExpectUniqueSample(histogram_prefix + "TotalUnfilled", 7, 1);
histogram_tester.ExpectUniqueSample(histogram_prefix + "Total", 14, 1);
}
// Test that we log the right number of autofilled fields at submission time.
TEST_F(AutofillMetricsTest, NumberOfAutofilledFieldsAtSubmission) {
// Set up our form data with two autofilled fields.
test::FormDescription form_description = {
.description_for_logging = "NumberOfAutofilledFields",
.fields = {{.role = NAME_FIRST,
.value = u"Elvis Aaron Presley",
.is_autofilled = true},
{.role = EMAIL_ADDRESS,
.value = u"buddy@gmail.com",
.is_autofilled = true},
{.role = NAME_FIRST, .value = u"", .is_autofilled = false},
{.role = EMAIL_ADDRESS,
.value = u"garbage",
.is_autofilled = false},
{.role = NO_SERVER_DATA,
.value = u"USA",
.form_control_type = "select-one",
.is_autofilled = false},
{.role = PHONE_HOME_CITY_AND_NUMBER,
.value = u"2345678901",
.form_control_type = "tel",
.is_autofilled = true}},
.unique_renderer_id = test::MakeFormRendererId(),
.main_frame_origin =
url::Origin::Create(autofill_client_->form_origin())};
FormData form = GetAndAddSeenForm(form_description);
SimulateUserChangedTextFieldWithoutActuallyChangingTheValue(form,
form.fields[1]);
base::HistogramTester histogram_tester;
SubmitForm(form);
// Test that the correct bucket for the number of filled fields received a
// count while the others remain at zero counts.
const size_t expected_number_of_accepted_fillings = 2;
const size_t expected_number_of_corrected_fillings = 1;
const size_t expected_number_of_total_fillings =
expected_number_of_accepted_fillings +
expected_number_of_corrected_fillings;
for (int i = 0; i < 50; i++) {
histogram_tester.ExpectBucketCount(
"Autofill.NumberOfAutofilledFieldsAtSubmission.Total", i,
i == expected_number_of_total_fillings ? 1 : 0);
histogram_tester.ExpectBucketCount(
"Autofill.NumberOfAutofilledFieldsAtSubmission.Accepted", i,
i == expected_number_of_accepted_fillings ? 1 : 0);
histogram_tester.ExpectBucketCount(
"Autofill.NumberOfAutofilledFieldsAtSubmission.Corrected", i,
i == expected_number_of_corrected_fillings ? 1 : 0);
}
}
// Test that we log the right number of autofilled fields with an unrecognized
// autocomplete attribute at submission time.
TEST_F(AutofillMetricsTest,
NumberOfAutofilledFieldsWithAutocompleteUnrecognizedAtSubmission) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndEnableFeature(
features::kAutofillFillAndImportFromMoreFields);
// Set up our form data with two autofilled fields.
test::FormDescription form_description = {
.description_for_logging = "NumberOfAutofilledFields",
.fields = {{.role = NAME_FULL,
.value = u"Elvis Aaron Presley",
.autocomplete_attribute = "garbage",
.is_autofilled = true},
{.role = EMAIL_ADDRESS,
.value = u"buddy@gmail.com",
.autocomplete_attribute = "garbage",
.is_autofilled = true},
{.role = NAME_FIRST, .value = u"", .is_autofilled = false},
{.role = EMAIL_ADDRESS,
.value = u"garbage",
.is_autofilled = false},
{.role = NO_SERVER_DATA,
.value = u"USA",
.form_control_type = "select-one",
.is_autofilled = false},
{.role = PHONE_HOME_CITY_AND_NUMBER,
.value = u"2345678901",
.form_control_type = "tel",
.is_autofilled = true}},
.unique_renderer_id = test::MakeFormRendererId(),
.main_frame_origin =
url::Origin::Create(autofill_client_->form_origin())};
FormData form = GetAndAddSeenForm(form_description);
// Simulate user changing the second and forth field of the form.
// TODO(crbug.com/1368096): Fix the metric to work independent of the final
// value.
SimulateUserChangedTextFieldWithoutActuallyChangingTheValue(form,
form.fields[1]);
SimulateUserChangedTextFieldWithoutActuallyChangingTheValue(form,
form.fields[3]);
base::HistogramTester histogram_tester;
SubmitForm(form);
// Test that the correct bucket for the number of filled fields with an
// unrecognized autocomplete attriute received a count while the others remain
// at zero counts.
const size_t expected_number_of_accepted_fillings = 1;
const size_t expected_number_of_corrected_fillings = 1;
const size_t expected_number_of_total_fillings =
expected_number_of_accepted_fillings +
expected_number_of_corrected_fillings;
for (int i = 0; i < 50; i++) {
histogram_tester.ExpectBucketCount(
"Autofill."
"NumberOfAutofilledFieldsWithAutocompleteUnrecognizedAtSubmission."
"Total",
i, i == expected_number_of_total_fillings ? 1 : 0);
histogram_tester.ExpectBucketCount(
"Autofill."
"NumberOfAutofilledFieldsWithAutocompleteUnrecognizedAtSubmission."
"Accepted",
i, i == expected_number_of_accepted_fillings ? 1 : 0);
histogram_tester.ExpectBucketCount(
"Autofill."
"NumberOfAutofilledFieldsWithAutocompleteUnrecognizedAtSubmission."
"Corrected",
i, i == expected_number_of_corrected_fillings ? 1 : 0);
}
}
struct Field {
ServerFieldType field_type;
bool is_autofilled = true;
absl::optional<std::u16string> value = absl::nullopt;
};
struct PerfectFillingTestCase {
std::string description;
std::vector<Field> fields;
std::vector<Bucket> address_buckets;
std::vector<Bucket> credit_card_buckets;
};
class AutofillPerfectFillingMetricsTest
: public AutofillMetricsTest,
public ::testing::WithParamInterface<PerfectFillingTestCase> {
public:
std::vector<test::FieldDescription> GetFields(std::vector<Field> fields) {
std::vector<test::FieldDescription> fields_to_return;
for (const auto& field : fields) {
test::FieldDescription f;
if (field.value) {
f.value = field.value;
} else if (field.field_type == NAME_FULL ||
field.field_type == CREDIT_CARD_NAME_FULL) {
f.value = u"Elvis Aaron Presley";
} else if (field.field_type == EMAIL_ADDRESS) {
f.value = u"buddy@gmail.com";
} else if (field.field_type == ADDRESS_HOME_CITY) {
f.value = u"Munich";
} else if (field.field_type == CREDIT_CARD_NUMBER) {
f.value = u"01230123012399";
} else {
NOTREACHED();
}
f.role = field.field_type;
f.is_autofilled = field.is_autofilled;
fields_to_return.push_back(f);
}
return fields_to_return;
}
};
INSTANTIATE_TEST_SUITE_P(
AutofillMetricsTest,
AutofillPerfectFillingMetricsTest,
testing::Values(
// Test that we log the perfect filling metric correctly for an address
// form in which every field is autofilled.
PerfectFillingTestCase{
"PerfectFillingForAddresses_AllAutofillFilled",
{{NAME_FULL}, {EMAIL_ADDRESS}, {ADDRESS_HOME_CITY}},
{Bucket(false, 0), Bucket(true, 1)},
{Bucket(false, 0), Bucket(true, 0)}},
// Test that we log the perfect filling metric correctly for an address
// form in which every field is autofilled or empty.
PerfectFillingTestCase{
"PerfectFillingForAddresses_AllAutofillFilledOrEmpty",
{{NAME_FULL}, {EMAIL_ADDRESS}, {ADDRESS_HOME_CITY, false, u""}},
{Bucket(false, 0), Bucket(true, 1)},
{Bucket(false, 0), Bucket(true, 0)}},
// Test that we log the perfect filling metric correctly for an address
// form in which a non-empty field is not autofilled.
PerfectFillingTestCase{
"PerfectFillingForAddresses_NotAllAutofilled",
{{NAME_FULL}, {EMAIL_ADDRESS}, {ADDRESS_HOME_CITY, false}},
{Bucket(false, 1), Bucket(true, 0)},
{Bucket(false, 0), Bucket(true, 0)}},
// Test that we log the perfect filling metric correctly for a credit
// card form in which every field is autofilled.
PerfectFillingTestCase{"PerfectFillingForCreditCards_AllAutofilled",
{{CREDIT_CARD_NAME_FULL}, {CREDIT_CARD_NUMBER}},
{Bucket(false, 0), Bucket(true, 0)},
{Bucket(false, 0), Bucket(true, 1)}},
// Test that we log the perfect filling metric correctly for a credit
// card form in which not every field is autofilled or empty.
PerfectFillingTestCase{
"PerfectFillingForCreditCards_NotAllAutofilled",
{{CREDIT_CARD_NAME_FULL}, {CREDIT_CARD_NUMBER, false}},
{Bucket(false, 0), Bucket(true, 0)},
{Bucket(false, 1), Bucket(true, 0)}},
// Test that we log the perfect filling metric correctly for a form that
// contains both credit card and address information. Here, the form is
// fully autofilled resulting in a perfect count for both addresses and
// credit cards.
PerfectFillingTestCase{"PerfectFillingForMixedForm_AllAutofilled",
{{NAME_FULL}, {CREDIT_CARD_NUMBER}},
{Bucket(false, 0), Bucket(true, 1)},
{Bucket(false, 0), Bucket(true, 1)}},
// Test that we log the perfect filling metric correctly for a form that
// contains both credit card and address information. Here, the form is
// not fully autofilled resulting in a non-perfect count for both
// addresses and credit cards.
PerfectFillingTestCase{"PerfectFillingForMixedForm_NotAllAutofilled",
{{NAME_FULL}, {CREDIT_CARD_NUMBER, false}},
{Bucket(false, 1), Bucket(true, 0)},
{Bucket(false, 1), Bucket(true, 0)}}));
TEST_P(AutofillPerfectFillingMetricsTest,
PerfectFilling_Addresses_CreditCards) {
auto test_case = GetParam();
FormData form =
test::GetFormData({.description_for_logging = test_case.description,
.fields = GetFields(test_case.fields),
.unique_renderer_id = test::MakeFormRendererId(),
.main_frame_origin = url::Origin::Create(
autofill_client_->form_origin())});
std::vector<ServerFieldType> field_types;
for (const auto& f : test_case.fields)
field_types.push_back(f.field_type);
autofill_manager().AddSeenForm(form, field_types);
base::HistogramTester histogram_tester;
SubmitForm(form);
EXPECT_THAT(
histogram_tester.GetAllSamples("Autofill.PerfectFilling.Addresses"),
BucketsAre(test_case.address_buckets));
EXPECT_THAT(
histogram_tester.GetAllSamples("Autofill.PerfectFilling.CreditCards"),
BucketsAre(test_case.credit_card_buckets));
}
struct TouchToFillForCreditCardsTestCase {
std::vector<Field> fields;
std::vector<bool> fields_is_autofilled_values;
bool is_all_autofilled;
bool is_all_accepted;
};
class TouchToFillForCreditCardsTest
: public AutofillMetricsTest,
public ::testing::WithParamInterface<TouchToFillForCreditCardsTestCase> {
public:
std::vector<FormFieldData> GetFields(std::vector<Field> fields) {
std::vector<FormFieldData> fields_to_return;
fields_to_return.reserve(fields.size());
for (const auto& field : fields) {
if (field.field_type == CREDIT_CARD_NAME_FULL) {
fields_to_return.push_back(
CreateField("Name on card", "cardName", "", "text"));
} else if (field.field_type == CREDIT_CARD_NUMBER) {
fields_to_return.push_back(
CreateField("Credit card number", "cardNumber", "", "text"));
} else if (field.field_type == CREDIT_CARD_EXP_MONTH) {
fields_to_return.push_back(
CreateField("Expiration date", "cc_exp", "", "text"));
} else if (field.field_type == CREDIT_CARD_VERIFICATION_CODE) {
fields_to_return.push_back(CreateField("CVC", "CVC", "", "text"));
} else {
NOTREACHED();
}
}
return fields_to_return;
}
void SetFieldsAutofilledValues(FormData& form,
std::vector<bool>& fields_is_autofilled_values,
std::vector<Field>& server_field_types) {
DCHECK(form.fields.size() == fields_is_autofilled_values.size());
DCHECK(form.fields.size() == server_field_types.size());
for (size_t i = 0; i < fields_is_autofilled_values.size(); i++) {
form.fields[i].is_autofilled = fields_is_autofilled_values[i];
CreditCard testCard = test::GetCreditCard();
form.fields[i].value =
server_field_types[i].field_type != CREDIT_CARD_VERIFICATION_CODE
? testCard.GetRawInfo(server_field_types[i].field_type)
: u"123";
}
}
};
TEST_P(TouchToFillForCreditCardsTest,
AllAutofilledAndAccepted_TouchToFill_CreditCards) {
RecreateCreditCards(true, false, false, false);
TouchToFillForCreditCardsTestCase test_case = GetParam();
FormData form = CreateForm(GetFields(test_case.fields));
SeeForm(form);
autofill_manager().OnAskForValuesToFillTest(form, form.fields[0], {},
AutoselectFirstSuggestion(false),
FormElementWasClicked(true));
base::HistogramTester histogram_tester;
// Simulate user selection in the payments bottom sheet
touch_to_fill_delgate_->SuggestionSelected(kTestLocalCardId);
// Simulate that fields were autofilled
SetFieldsAutofilledValues(form, test_case.fields_is_autofilled_values,
test_case.fields);
// Simulate user made change to autofilled field
if (!test_case.is_all_accepted) {
SimulateUserChangedTextField(form, form.fields[0]);
}
SubmitForm(form);
ResetDriverToCommitMetrics();
EXPECT_EQ(histogram_tester.GetBucketCount(
"Autofill.TouchToFill.CreditCard.PerfectFilling",
test_case.is_all_autofilled && test_case.is_all_accepted),
1);
EXPECT_EQ(histogram_tester.GetBucketCount(
"Autofill.FillingCorrectnessByMethod.CreditCard.TouchToFill",
test_case.is_all_accepted),
1);
}
INSTANTIATE_TEST_SUITE_P(
AutofillMetricsTest,
TouchToFillForCreditCardsTest,
testing::Values(
// All autofilled and nothing edited manually
TouchToFillForCreditCardsTestCase{
{{CREDIT_CARD_NAME_FULL},
{CREDIT_CARD_NUMBER},
{CREDIT_CARD_EXP_MONTH}},
/*fields_is_autofilled_values=*/{true, true, true},
/*is_all_autofilled=*/true,
/*is_all_accepted=*/true},
// Not all autofilled and nothing edited manually
TouchToFillForCreditCardsTestCase{
{{CREDIT_CARD_NAME_FULL},
{CREDIT_CARD_NUMBER},
{CREDIT_CARD_EXP_MONTH},
{CREDIT_CARD_VERIFICATION_CODE}},
/*fields_is_autofilled_values=*/{true, true, true, false},
/*is_all_autofilled=*/false,
/*is_all_accepted=*/true},
// Not all autofilled and something edited manually
TouchToFillForCreditCardsTestCase{
{{CREDIT_CARD_NAME_FULL},
{CREDIT_CARD_NUMBER},
{CREDIT_CARD_EXP_MONTH},
{CREDIT_CARD_VERIFICATION_CODE}},
/*fields_is_autofilled_values=*/{true, true, true, false},
/*is_all_autofilled=*/false,
/*is_all_accepted=*/false}));
// Test the emission of collisions between NUMERIC_QUANTITY and server
// predictions as well as the potential false positives.
TEST_F(AutofillMetricsTest, NumericQuantityCollision) {
// Those metrics are only collected when the numeric quantities are not
// getting precedence over server predictions.
base::test::ScopedFeatureList numeric_quanity_feature_list;
numeric_quanity_feature_list.InitAndDisableFeature(
features::kAutofillGivePrecedenceToNumericQuantitites);
// Set up our form data.
test::FormDescription form_description = {
.description_for_logging = "NumericQuantityCollision",
.fields = {{.server_type = NO_SERVER_DATA,
.heuristic_type = NUMERIC_QUANTITY,
.is_autofilled = false},
// We add a second field to make sure the metrics are only
// recorded for the field with the numeric quantity prediction.
{.server_type = ADDRESS_HOME_LINE1,
.heuristic_type = ADDRESS_HOME_LINE1,
.is_autofilled = false}}};
// Helper to submit the `form` and test the expectations. `collision`
// indicates that there was a collision between the NUMERIC_QUANTITY
// prediction and a server prediction.
// If `autofill_used` and a `collision` exists, the histogram to
// track `false_positive` is checked.
auto SubmitAndTest = [this](const FormData& form, bool collision,
bool autofill_used, bool false_positive) {
base::HistogramTester histogram_tester;
SubmitForm(form);
histogram_tester.ExpectUniqueSample(
"Autofill.NumericQuantityCollidesWithServerPrediction", collision, 1);
if (collision && autofill_used) {
histogram_tester.ExpectUniqueSample(
"Autofill.AcceptedFilledFieldWithNumericQuantityHeuristicPrediction",
false_positive, 1);
}
};
{
SCOPED_TRACE(
"No collision case - The numeric quanity does not collide with a "
"server prediction.");
FormData form = GetAndAddSeenForm(form_description);
SubmitAndTest(form, /*collision=*/false, /*autofill_used=*/false,
/*false_positive=*/false);
}
{
SCOPED_TRACE("Collision, but nothing is filled.");
// Add a server prediction to create a collision.
form_description.fields[0].server_type = NAME_FIRST;
FormData form = GetAndAddSeenForm(form_description);
SubmitAndTest(form, /*collision=*/true, /*autofill_used=*/false,
/*false_positive=*/false);
}
{
SCOPED_TRACE("Collision, the field is autofilled.");
form_description.fields[0].is_autofilled = true;
FormData form = GetAndAddSeenForm(form_description);
SubmitAndTest(form, /*collision=*/true, /*autofill_used=*/true,
/*false_positive=*/true);
}
{
SCOPED_TRACE(
"Collision, the field is autofilled and subsequently changed.");
FormData form = GetAndAddSeenForm(form_description);
SimulateUserChangedTextField(form, form.fields[0]);
SubmitAndTest(form, /*collision=*/true, /*autofill_used=*/true,
/*false_positive=*/false);
}
}
// Test that we log quality metrics appropriately.
TEST_F(AutofillMetricsTest, QualityMetrics) {
// Set up our form data.
test::FormDescription form_description = {
.description_for_logging = "QualityMetrics",
.fields = {{.role = NAME_FIRST,
.heuristic_type = NAME_FULL,
.value = u"Elvis Aaron Presley",
.is_autofilled = true},
{.role = EMAIL_ADDRESS,
.heuristic_type = PHONE_HOME_NUMBER,
.value = u"buddy@gmail.com",
.is_autofilled = false},
{.role = NAME_FIRST,
.heuristic_type = NAME_FULL,
.value = u"",
.is_autofilled = false},
{.role = EMAIL_ADDRESS,
.heuristic_type = PHONE_HOME_NUMBER,
.value = u"garbage",
.is_autofilled = false},
{.role = NO_SERVER_DATA,
.heuristic_type = UNKNOWN_TYPE,
.value = u"USA",
.form_control_type = "select-one",
.is_autofilled = false},
{.role = PHONE_HOME_CITY_AND_NUMBER,
.heuristic_type = PHONE_HOME_CITY_AND_NUMBER,
.value = u"2345678901",
.form_control_type = "tel",
.is_autofilled = true}},
.unique_renderer_id = test::MakeFormRendererId(),
.main_frame_origin =
url::Origin::Create(autofill_client_->form_origin())};
std::vector<ServerFieldType> heuristic_types = {
NAME_FULL, PHONE_HOME_NUMBER, NAME_FULL,
PHONE_HOME_NUMBER, UNKNOWN_TYPE, PHONE_HOME_CITY_AND_NUMBER};
std::vector<ServerFieldType> server_types = {
NAME_FIRST, EMAIL_ADDRESS, NAME_FIRST,
EMAIL_ADDRESS, NO_SERVER_DATA, PHONE_HOME_CITY_AND_NUMBER};
FormData form = GetAndAddSeenForm(form_description);
base::HistogramTester histogram_tester;
SubmitForm(form);
// Auxiliary function for GetAllSamples() expectations.
auto b = [](ServerFieldType field_type,
AutofillMetrics::FieldTypeQualityMetric metric,
base::HistogramBase::Count count) {
return Bucket(GetFieldTypeGroupPredictionQualityMetric(field_type, metric),
count);
};
// Heuristic predictions.
EXPECT_THAT(histogram_tester.GetAllSamples(
"Autofill.FieldPredictionQuality.Aggregate.Heuristic"),
BucketsAre(Bucket(AutofillMetrics::FALSE_NEGATIVE_UNKNOWN, 1),
Bucket(AutofillMetrics::TRUE_POSITIVE, 2),
Bucket(AutofillMetrics::FALSE_POSITIVE_EMPTY, 1),
Bucket(AutofillMetrics::FALSE_POSITIVE_UNKNOWN, 1),
Bucket(AutofillMetrics::FALSE_NEGATIVE_MISMATCH, 1)));
EXPECT_THAT(
histogram_tester.GetAllSamples(