Skip to content

Commit

Permalink
Add "-target-feature +aes" to the arm crc32c build flags.
Browse files Browse the repository at this point in the history
The code uses intrinsics that require +aes. It looks like the build file used to pass "-march=armv8-a+crc+crypto" but replaced that with "-march=armv8" and separate -target-feature flags. "-march=armv8-a+crc+crypto" expands to include the driver flag "target-feature +aes", so we should include that here too.

Bug: 1405048
Change-Id: I30497d8dc3bfe8c954851659d81b8a3d20b584b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4137218
Reviewed-by: Austin Sullivan <asully@chromium.org>
Commit-Queue: Amy Huang <akhuang@google.com>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1089373}
  • Loading branch information
amykhuang authored and Chromium LUCI CQ committed Jan 5, 2023
1 parent 34241bf commit 9f43d82
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions third_party/crc32c/BUILD.gn
Expand Up @@ -122,6 +122,10 @@ source_set("crc32c_arm64") {
"-target-feature",
"-Xclang",
"+crypto",
"-Xclang",
"-target-feature",
"-Xclang",
"+aes",
]
} else {
cflags = [ "-march=armv8-a+crc+crypto" ]
Expand Down

0 comments on commit 9f43d82

Please sign in to comment.