Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using stdout as loader destination, results shouldn't be interlaced with UI updates #31

Closed
hyfen opened this issue Mar 11, 2022 · 0 comments
Closed

When using stdout as loader destination, results shouldn't be interlaced with UI updates #31

hyfen opened this issue Mar 11, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@hyfen
Copy link
Member

hyfen commented Mar 11, 2022

image

(There's also a race condition: if job runs quickly, progress bar updates won't display in between outputs)

The naive/inefficient solution would be to detect stdout as destination, buffer all output, and then only print it in the loader#finish call.
@hyfen hyfen added the bug Something isn't working label Mar 11, 2022
@hyfen hyfen closed this as completed in 6696e61 Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hyfen