Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Intermittent failure in TestInputCallbackDangle test #56

Closed
pwhelan opened this issue Oct 20, 2023 · 0 comments
Closed

[BUG] Intermittent failure in TestInputCallbackDangle test #56

pwhelan opened this issue Oct 20, 2023 · 0 comments

Comments

@pwhelan
Copy link
Contributor

pwhelan commented Oct 20, 2023

Summary

The TestInputCallbackDangle test fails intermittently with a panic on sending to a closed channel. This was introduced in my PR #43 or one of its descendants. For now it is mitigated in CI by retrying the tests several times but it should be fixed.

go test -v ./
=== RUN   TestInputCallbackCtrlC
2023/10/20 12:25:11 goroutine will be stopping: name=""
--- PASS: TestInputCallbackCtrlC (0.00s)
=== RUN   TestInputCallbackDangle
panic: send on closed channel

goroutine 66 [running]:
github.com/calyptia/plugin.testPluginInputCallbackDangle.Collect(...)
	/home/pwhelan/Projects/work/flb/plugins/flb-go-plugin/cshared_test.go:74
github.com/calyptia/plugin.prepareInputCollector.func1.1(0xc0000ac480?)
	/home/pwhelan/Projects/work/flb/plugins/flb-go-plugin/cshared.go:206 +0x3f
created by github.com/calyptia/plugin.prepareInputCollector.func1 in goroutine 50
	/home/pwhelan/Projects/work/flb/plugins/flb-go-plugin/cshared.go:205 +0xfa
FAIL	github.com/calyptia/plugin	0.005s
FAIL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants