Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add test_issue_866" #1238

Merged
merged 1 commit into from Aug 31, 2023
Merged

Conversation

pitdicker
Copy link
Collaborator

The test added in #1077 is pretty much guaranteed to cause trouble.

We don't know if any arbitrary DateTime<Local> will exist, such as 2022-11-06T01:02:60 in that test. It may fall in a DST transition and not exist or be ambiguous.

The fix for #866 in #1064 took this into account, and #1077 added the failure mode right back 馃槃.

Fixes #1236.

This reverts commit bf9f876.
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1238 (0ea10d5) into 0.4.x (243d26d) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            0.4.x    #1238      +/-   ##
==========================================
- Coverage   86.10%   85.83%   -0.28%     
==========================================
  Files          37       37              
  Lines       13522    13516       -6     
==========================================
- Hits        11643    11601      -42     
- Misses       1879     1915      +36     
Files Changed Coverage 螖
src/offset/local/mod.rs 83.52% <酶> (-5.49%) 猬囷笍

... and 2 files with indirect coverage changes

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@pitdicker pitdicker merged commit 18f1c90 into 0.4.x Aug 31, 2023
36 checks passed
@pitdicker pitdicker deleted the revert-1077-Issue866_add_test_case branch August 31, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants