Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arbitrary string slicing in parse_rfc3339_relaxed #1254

Merged
merged 1 commit into from Sep 5, 2023

Conversation

pitdicker
Copy link
Collaborator

Introduced in #1145.

Fixes #1253.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #1254 (0e14716) into 0.4.x (e39346e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            0.4.x    #1254   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files          37       37           
  Lines       16452    16453    +1     
=======================================
+ Hits        15040    15041    +1     
  Misses       1412     1412           
Files Changed Coverage Δ
src/datetime/tests.rs 96.51% <100.00%> (+<0.01%) ⬆️
src/format/parse.rs 97.23% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@djc djc merged commit 5a6b2b4 into chronotope:0.4.x Sep 5, 2023
37 checks passed
@pitdicker pitdicker deleted the parse_rfc3339_relaxed_panic branch September 5, 2023 07:26
jjbayer added a commit to getsentry/relay that referenced this pull request Sep 5, 2023
Make `chrono` a git dependency temporarily to prevent panics. We can
bump to chrono `0.4.29` once
chronotope/chrono#1254 is released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants