Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source attribution #7

Open
charles-cooper opened this issue Apr 20, 2019 · 2 comments
Open

Source attribution #7

charles-cooper opened this issue Apr 20, 2019 · 2 comments

Comments

@charles-cooper
Copy link

Hello and thanks for putting together this great repository :). I noticed while reading https://github.com/chronoxor/CppTrader/blob/master/performance/market_manager_optimized_aggressive.cpp that many portions are substantially similar to an implementation I published, https://github.com/charles-cooper/itch-order-book/blob/master/order_book.h, but with no attribution. I recognize that you have licenses and copyrights on your own code, and I'm sure you would like others to respect those, so please do your part in upholding the tenets of the open source community and follow the terms of my license https://github.com/charles-cooper/itch-order-book/blob/master/LICENSE :).

@chronoxor
Copy link
Owner

Hello Charles! During creating a prototype of the fast matching engine I took many ideas from your repository and others. Of course I can put all necessary references and licensing. However I'm not a licence expert. I took MIT license as most open and put everything in opensource under it. Will it be enough if I put a reference to your "itch-order-book" repository with your BSD 3-Clause License content in my source code?

@charles-cooper
Copy link
Author

Will it be enough if I put a reference to your "itch-order-book" repository with your BSD 3-Clause License content in my source code?

That works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants