-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some bug in receiver when parsing final model #12
Comments
8 bytes (4 byte size & 4 bytes offset) is minimal struct size, which could be included into another struct. For root structs which are send / received we need two more fields - 4 bytes total size and 4 bytes offset. See FBE spec for details - https://chronoxor.github.io/FastBinaryEncoding/documents/FBE.html#structs |
In specification said that minimal size of FINAL struct is 8 bytes: Final model struct properties: Root struct size = 8 + sizeof(fileds) And this assert is working for Final model too. If you pass empty struct to FinalSender and then will try to pass buffer to FinalReceiver, this assert will fail. (model should be compiled with --final and --sender flags). Tested on java |
Reproduced! Fix will be available soon. |
Fixed! |
Hello. Minimal size of final model struct is 8 bytes, but this assert is checking that message_size is larger than 16 bytes
FastBinaryEncoding/source/generator_cpp.cpp
Line 4513 in 393e6ee
Is this kind of bug or I am just using wrong compilation options?
The text was updated successfully, but these errors were encountered: