New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libfmt issue for cpp #75

Open

wg485733 opened this issue Oct 25, 2022 · 1 comment

wg485733 commented Oct 25, 2022 •

edited

Loading

2 issues

in this commit, the macro only checks for FMT_VERSION. but ostream_formatter is only introduced after fmt 9.0.0. So the generated code would fail with earlier version of fmt.
think the user needs to include fmt/ostream.h header file for this to work? while FMT_VERSION is defined in fmt/core.h, so it's worth mentioning that user should include fmt/ostream.h if she already includes fmt/core.h

The text was updated successfully, but these errors were encountered:

chronoxor added a commit that referenced this issue


          libfmt issue for cpp #75

f2134da

Owner

chronoxor commented Oct 26, 2022

Fixed with #if defined(FMT_VERSION) && (FMT_VERSION >= 90000) check. Earlier {fmt} versions are not supported anymore
Corresponding README.md section is updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment